From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754464AbbIKXor (ORCPT ); Fri, 11 Sep 2015 19:44:47 -0400 Received: from lucky1.263xmail.com ([211.157.147.133]:35241 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753852AbbIKXoq (ORCPT ); Fri, 11 Sep 2015 19:44:46 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 220.200.5.245 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 2/2] ARM: dts: support Highspeed for rk3066a platform To: =?UTF-8?Q?Heiko_St=c3=bcbner?= References: <1441956268-10418-1-git-send-email-shawn.lin@rock-chips.com> <1441956341-10623-1-git-send-email-shawn.lin@rock-chips.com> <25757012.mQz0HMffNZ@diego> Cc: shawn.lin@rock-chips.com, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org From: Shawn Lin Message-ID: <55F36765.2040703@rock-chips.com> Date: Sat, 12 Sep 2015 07:44:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <25757012.mQz0HMffNZ@diego> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2015/9/12 6:45, Heiko Stübner 写道: > Hi Shawn, > > Am Freitag, 11. September 2015, 15:25:41 schrieb Shawn Lin: >> Add cap-sd-highspeed and cap-mmc-highspeed for rk3066a >> platform to make sd cards running faster. >> >> Signed-off-by: Shawn Lin >> --- >> >> arch/arm/boot/dts/rk3066a.dtsi | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm/boot/dts/rk3066a.dtsi b/arch/arm/boot/dts/rk3066a.dtsi >> index 946f187..b50a785 100644 >> --- a/arch/arm/boot/dts/rk3066a.dtsi >> +++ b/arch/arm/boot/dts/rk3066a.dtsi >> @@ -595,6 +595,8 @@ >> &mmc0 { >> pinctrl-names = "default"; >> pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_cd &sd0_bus4>; >> + cap-mmc-highspeed; >> + cap-sd-highspeed; >> }; >> > > Currently we're setting the dw_mmc capabilities in the individual board files > and patch1 also correctly adds the cap to the radxarock file. > Thanks, Heiko. :) Right, I was condering add caps in rk3066a for all boards which include it or for each individual board. Unfortunately, I chose the wrong one.:( Done in the v2. > So I'd think we should stay with one scheme and probably add the rk3066 caps > to the bqcurie2, marsboard and rayeager where applicable. > > > Heiko > > > -- Best Regards Shawn Lin