From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755029AbbIMBez (ORCPT ); Sat, 12 Sep 2015 21:34:55 -0400 Received: from bubo.tul.cz ([147.230.16.1]:60183 "EHLO bubo.tul.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754889AbbIMBex (ORCPT ); Sat, 12 Sep 2015 21:34:53 -0400 Subject: Re: [PATCH v2 2/3] net: irda: pxaficp_ir: convert to readl and writel To: Robert Jarzmik , Samuel Ortiz References: <1442058324-9760-1-git-send-email-robert.jarzmik@free.fr> <1442058324-9760-2-git-send-email-robert.jarzmik@free.fr> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann From: Petr Cvek Message-ID: <55F4D2B6.7020605@tul.cz> Date: Sun, 13 Sep 2015 03:34:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1442058324-9760-2-git-send-email-robert.jarzmik@free.fr> Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne 12.9.2015 v 13:45 Robert Jarzmik napsal(a): > Convert the pxa IRDA driver to readl and writel primitives, and remove > another set of direct registers access. This leaves only the DMA > registers access, which will be dealt with dmaengine conversion. > > Signed-off-by: Robert Jarzmik > --- > Since v1: modified __REG macro to cope with STIER, ST* registers > --- > drivers/net/irda/pxaficp_ir.c | 210 +++++++++++++++++++++++++----------------- > 1 file changed, 126 insertions(+), 84 deletions(-) > > diff --git a/drivers/net/irda/pxaficp_ir.c b/drivers/net/irda/pxaficp_ir.c > index b1794998c68e..4a2b3f71e4a8 100644 > --- a/drivers/net/irda/pxaficp_ir.c > +++ b/drivers/net/irda/pxaficp_ir.c > @@ -29,15 +29,16 @@ > > #include > #include > +#undef __REG > +#define __REG(x) ((x) & 0xffff) > #include What are future plans for the definitions in the mach/regs-uart.h ? Maybe it would be better to duplicate register definition in ficp source code (it seems that normal PXA UART driver does not use these ones). But random searches shows, that at least base address register: #define STUART STRBR #define STRBR __REG(0x40700000) /* Receive Buffer Register (read only) */ is used in machine init source codes. I can look at it in the "near" future (if I don't forget :-D). In other case patchset works, as it has been tested for SIR part. Tested-by: Petr Cvek