Re: [PATCH V2 3/3] reset: hi6220: Reset driver for hisilicon hi6220 SoC

Arnd Bergmann
2015-09-11T08:41:50Z

On Friday 11 September 2015 16:18:38 Chen Feng wrote:
> +static int __init hi6220_reset_init(void)
> +{
> + int ret;
> + struct device_node *np;
> + struct hi6220_reset_data *data;
> +
> + data = kzalloc(sizeof(*data), GFP_KERNEL);
> + if (!data)
> + return -ENOMEM;
> +
> + np = of_find_compatible_node(NULL, NULL, "hisilicon,hi6220_reset_ctl");
> + if (!np) {
> + ret = -ENXIO;
> + goto err_alloc;
> + }

Why is this not a platform driver?

> + if (IS_ENABLED(CONFIG_RESET_CONTROLLER))
> + reset_controller_register(&data->rc_dev);
> +
> + return 0;

The Kconfig symbol already depends on RESET_CONTROLLER, so
the IS_ENABLED() check looks redundant.

Arnd