From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754080AbbINCZV (ORCPT ); Sun, 13 Sep 2015 22:25:21 -0400 Received: from mga14.intel.com ([192.55.52.115]:41623 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753417AbbINCZT (ORCPT ); Sun, 13 Sep 2015 22:25:19 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,525,1437462000"; d="scan'208";a="644197092" Subject: Re: [PATCH] platform-msi: Do not cache msi_desc in handler_data To: Marc Zyngier , Thomas Gleixner References: <1442147824-20971-1-git-send-email-marc.zyngier@arm.com> Cc: Ma Jun , linux-kernel@vger.kernel.org From: Jiang Liu Organization: Intel Message-ID: <55F6300C.6060905@linux.intel.com> Date: Mon, 14 Sep 2015 10:25:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1442147824-20971-1-git-send-email-marc.zyngier@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/9/13 20:37, Marc Zyngier wrote: > The current implementation of platform MSI caches the msi_desc > pointer in irq_data::handler_data. This is a bit silly, as > we also have irq_data::msi_desc, which is perfectly valid. > > Remove the useless assignment and simplify the whole flow. > > Reported-by: Ma Jun > Signed-off-by: Marc Zyngier Reviewed-by: Jiang Liu > --- > drivers/base/platform-msi.c | 18 +++--------------- > 1 file changed, 3 insertions(+), 15 deletions(-) > > diff --git a/drivers/base/platform-msi.c b/drivers/base/platform-msi.c > index 1857a5d..134483d 100644 > --- a/drivers/base/platform-msi.c > +++ b/drivers/base/platform-msi.c > @@ -63,20 +63,8 @@ static int platform_msi_init(struct irq_domain *domain, > unsigned int virq, irq_hw_number_t hwirq, > msi_alloc_info_t *arg) > { > - struct irq_data *data; > - > - irq_domain_set_hwirq_and_chip(domain, virq, hwirq, > - info->chip, info->chip_data); > - > - /* > - * Save the MSI descriptor in handler_data so that the > - * irq_write_msi_msg callback can retrieve it (and the > - * associated device). > - */ > - data = irq_domain_get_irq_data(domain, virq); > - data->handler_data = arg->desc; > - > - return 0; > + return irq_domain_set_hwirq_and_chip(domain, virq, hwirq, > + info->chip, info->chip_data); > } > #else > #define platform_msi_set_desc NULL > @@ -97,7 +85,7 @@ static void platform_msi_update_dom_ops(struct msi_domain_info *info) > > static void platform_msi_write_msg(struct irq_data *data, struct msi_msg *msg) > { > - struct msi_desc *desc = irq_data_get_irq_handler_data(data); > + struct msi_desc *desc = irq_data_get_msi_desc(data); > struct platform_msi_priv_data *priv_data; > > priv_data = desc->platform.msi_priv_data; >