From: Jens Axboe <axboe@kernel.dk>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Bart Van Assche <bart.vanassche@sandisk.com>
Subject: Re: [PATCH] block: kmemleak: Track the page allocations for struct request
Date: Mon, 14 Sep 2015 11:21:58 -0600 [thread overview]
Message-ID: <55F70236.1030306@kernel.dk> (raw)
In-Reply-To: <1442250962-9906-1-git-send-email-catalin.marinas@arm.com>
On 09/14/2015 11:16 AM, Catalin Marinas wrote:
> The pages allocated for struct request contain pointers to other slab
> allocations (via ops->init_request). Since kmemleak does not track/scan
> page allocations, the slab objects will be reported as leaks (false
> positives). This patch adds kmemleak callbacks to allow tracking of such
> pages.
>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> Reported-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Tested-by: Bart Van Assche<bart.vanassche@sandisk.com>
> Cc: Christoph Hellwig <hch@infradead.org>
> Cc: Jens Axboe <axboe@kernel.dk>
> ---
>
> Jens,
>
> I just realised that no-one has picked this patch up for -rc1. It was
> discussed here previously:
>
> http://lkml.kernel.org/r/20150803104309.GB4033@e104818-lin.cambridge.arm.com
>
> Since it touches the block layer, are you fine with merging it?
Yeah looks simple enough for me, not sure why it got missed. I'll add it
for 4.4-rc1, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2015-09-14 17:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 17:16 [PATCH] block: kmemleak: Track the page allocations for struct request Catalin Marinas
2015-09-14 17:21 ` Jens Axboe [this message]
2015-11-25 11:04 ` William Dauchy
2015-11-25 16:45 ` Jens Axboe
2015-11-25 17:07 ` William Dauchy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F70236.1030306@kernel.dk \
--to=axboe@kernel.dk \
--cc=bart.vanassche@sandisk.com \
--cc=catalin.marinas@arm.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).