From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755127AbbINRWB (ORCPT ); Mon, 14 Sep 2015 13:22:01 -0400 Received: from mail-io0-f181.google.com ([209.85.223.181]:35380 "EHLO mail-io0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752904AbbINRWA (ORCPT ); Mon, 14 Sep 2015 13:22:00 -0400 Subject: Re: [PATCH] block: kmemleak: Track the page allocations for struct request To: Catalin Marinas References: <1442250962-9906-1-git-send-email-catalin.marinas@arm.com> Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , Bart Van Assche From: Jens Axboe Message-ID: <55F70236.1030306@kernel.dk> Date: Mon, 14 Sep 2015 11:21:58 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1442250962-9906-1-git-send-email-catalin.marinas@arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/14/2015 11:16 AM, Catalin Marinas wrote: > The pages allocated for struct request contain pointers to other slab > allocations (via ops->init_request). Since kmemleak does not track/scan > page allocations, the slab objects will be reported as leaks (false > positives). This patch adds kmemleak callbacks to allow tracking of such > pages. > > Signed-off-by: Catalin Marinas > Reported-by: Bart Van Assche > Tested-by: Bart Van Assche > Cc: Christoph Hellwig > Cc: Jens Axboe > --- > > Jens, > > I just realised that no-one has picked this patch up for -rc1. It was > discussed here previously: > > http://lkml.kernel.org/r/20150803104309.GB4033@e104818-lin.cambridge.arm.com > > Since it touches the block layer, are you fine with merging it? Yeah looks simple enough for me, not sure why it got missed. I'll add it for 4.4-rc1, thanks. -- Jens Axboe