public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Trevor Woerner <twoerner@gmail.com>
To: Anjali Menon <cse.anjalimenon@gmail.com>, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, andreas.dilger@intel.com,
	kp.balavasu@gmail.com, linux-kernel@vger.kernel.org,
	oleg.drokin@intel.com, joe@perches.com
Subject: Re: [PATCH] staging: lustre: lnet: lnet: Added a space
Date: Mon, 14 Sep 2015 17:15:30 -0400	[thread overview]
Message-ID: <55F738F2.3030808@gmail.com> (raw)
In-Reply-To: <1442139290-19743-1-git-send-email-cse.anjalimenon@gmail.com>

On 09/13/15 06:14, Anjali Menon wrote:
> Added a space to fix the following coding style warning detected by
> checkpatch:

Both your commit title and message say (or imply) you've added a space,
but this patch, in fact, removes a space, doesn't it?

> WARNING: space prohibited between function name and open parenthesis '('
>
> Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com>
> ---
>  drivers/staging/lustre/lnet/lnet/router.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lnet/lnet/router.c b/drivers/staging/lustre/lnet/lnet/router.c
> index 8510bae..be23e06 100644
> --- a/drivers/staging/lustre/lnet/lnet/router.c
> +++ b/drivers/staging/lustre/lnet/lnet/router.c
> @@ -1511,7 +1511,7 @@ lnet_notify(lnet_ni_t *ni, lnet_nid_t nid, int alive, unsigned long when)
>  	unsigned long		now = cfs_time_current();
>  	int			cpt = lnet_cpt_of_nid(nid);
>  
> -	LASSERT(!in_interrupt ());
> +	LASSERT(!in_interrupt());
>  
>  	CDEBUG(D_NET, "%s notifying %s: %s\n",
>  		(ni == NULL) ? "userspace" : libcfs_nid2str(ni->ni_nid),


  reply	other threads:[~2015-09-14 21:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-13 10:14 [PATCH] staging: lustre: lnet: lnet: Added a space Anjali Menon
2015-09-14 21:15 ` Trevor Woerner [this message]
2015-09-16 11:42 ` [PATCH v2] staging: lustre: lnet: lnet: Removed " Anjali Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F738F2.3030808@gmail.com \
    --to=twoerner@gmail.com \
    --cc=andreas.dilger@intel.com \
    --cc=cse.anjalimenon@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=kp.balavasu@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox