public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: lustre: lnet: lnet: Added a space
@ 2015-09-13 10:14 Anjali Menon
  2015-09-14 21:15 ` Trevor Woerner
  2015-09-16 11:42 ` [PATCH v2] staging: lustre: lnet: lnet: Removed " Anjali Menon
  0 siblings, 2 replies; 3+ messages in thread
From: Anjali Menon @ 2015-09-13 10:14 UTC (permalink / raw)
  To: gregkh
  Cc: oleg.drokin, andreas.dilger, kp.balavasu, linux-kernel, devel,
	joe, Anjali Menon

Added a space to fix the following coding style warning detected by
checkpatch:

WARNING: space prohibited between function name and open parenthesis '('

Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com>
---
 drivers/staging/lustre/lnet/lnet/router.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lnet/lnet/router.c b/drivers/staging/lustre/lnet/lnet/router.c
index 8510bae..be23e06 100644
--- a/drivers/staging/lustre/lnet/lnet/router.c
+++ b/drivers/staging/lustre/lnet/lnet/router.c
@@ -1511,7 +1511,7 @@ lnet_notify(lnet_ni_t *ni, lnet_nid_t nid, int alive, unsigned long when)
 	unsigned long		now = cfs_time_current();
 	int			cpt = lnet_cpt_of_nid(nid);
 
-	LASSERT(!in_interrupt ());
+	LASSERT(!in_interrupt());
 
 	CDEBUG(D_NET, "%s notifying %s: %s\n",
 		(ni == NULL) ? "userspace" : libcfs_nid2str(ni->ni_nid),
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: lustre: lnet: lnet: Added a space
  2015-09-13 10:14 [PATCH] staging: lustre: lnet: lnet: Added a space Anjali Menon
@ 2015-09-14 21:15 ` Trevor Woerner
  2015-09-16 11:42 ` [PATCH v2] staging: lustre: lnet: lnet: Removed " Anjali Menon
  1 sibling, 0 replies; 3+ messages in thread
From: Trevor Woerner @ 2015-09-14 21:15 UTC (permalink / raw)
  To: Anjali Menon, gregkh
  Cc: devel, andreas.dilger, kp.balavasu, linux-kernel, oleg.drokin,
	joe

On 09/13/15 06:14, Anjali Menon wrote:
> Added a space to fix the following coding style warning detected by
> checkpatch:

Both your commit title and message say (or imply) you've added a space,
but this patch, in fact, removes a space, doesn't it?

> WARNING: space prohibited between function name and open parenthesis '('
>
> Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com>
> ---
>  drivers/staging/lustre/lnet/lnet/router.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lnet/lnet/router.c b/drivers/staging/lustre/lnet/lnet/router.c
> index 8510bae..be23e06 100644
> --- a/drivers/staging/lustre/lnet/lnet/router.c
> +++ b/drivers/staging/lustre/lnet/lnet/router.c
> @@ -1511,7 +1511,7 @@ lnet_notify(lnet_ni_t *ni, lnet_nid_t nid, int alive, unsigned long when)
>  	unsigned long		now = cfs_time_current();
>  	int			cpt = lnet_cpt_of_nid(nid);
>  
> -	LASSERT(!in_interrupt ());
> +	LASSERT(!in_interrupt());
>  
>  	CDEBUG(D_NET, "%s notifying %s: %s\n",
>  		(ni == NULL) ? "userspace" : libcfs_nid2str(ni->ni_nid),


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2] staging: lustre: lnet: lnet: Removed a space
  2015-09-13 10:14 [PATCH] staging: lustre: lnet: lnet: Added a space Anjali Menon
  2015-09-14 21:15 ` Trevor Woerner
@ 2015-09-16 11:42 ` Anjali Menon
  1 sibling, 0 replies; 3+ messages in thread
From: Anjali Menon @ 2015-09-16 11:42 UTC (permalink / raw)
  To: gregkh
  Cc: oleg.drokin, andreas.dilger, kp.balavasu, linux-kernel, devel,
	Anjali Menon

Removed a space to fix the following coding style warning detected by
checkpatch:

WARNING: space prohibited between function name and open parenthesis '('

Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com>
---

Modified the subject

 drivers/staging/lustre/lnet/lnet/router.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lnet/lnet/router.c b/drivers/staging/lustre/lnet/lnet/router.c
index 8510bae..be23e06 100644
--- a/drivers/staging/lustre/lnet/lnet/router.c
+++ b/drivers/staging/lustre/lnet/lnet/router.c
@@ -1511,7 +1511,7 @@ lnet_notify(lnet_ni_t *ni, lnet_nid_t nid, int alive, unsigned long when)
 	unsigned long		now = cfs_time_current();
 	int			cpt = lnet_cpt_of_nid(nid);
 
-	LASSERT(!in_interrupt ());
+	LASSERT(!in_interrupt());
 
 	CDEBUG(D_NET, "%s notifying %s: %s\n",
 		(ni == NULL) ? "userspace" : libcfs_nid2str(ni->ni_nid),
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-09-16 11:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-13 10:14 [PATCH] staging: lustre: lnet: lnet: Added a space Anjali Menon
2015-09-14 21:15 ` Trevor Woerner
2015-09-16 11:42 ` [PATCH v2] staging: lustre: lnet: lnet: Removed " Anjali Menon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox