From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752483AbbIOBjP (ORCPT ); Mon, 14 Sep 2015 21:39:15 -0400 Received: from gproxy4-pub.mail.unifiedlayer.com ([69.89.23.142]:35525 "HELO gproxy4-pub.mail.unifiedlayer.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752404AbbIOBjO (ORCPT ); Mon, 14 Sep 2015 21:39:14 -0400 X-Authority-Analysis: v=2.1 cv=QdD14Krv c=1 sm=1 tr=0 a=6lV6tj8ir7tGSl/9xQZNPA==:117 a=6lV6tj8ir7tGSl/9xQZNPA==:17 a=cNaOj0WVAAAA:8 a=f5113yIGAAAA:8 a=N54-gffFAAAA:8 a=N659UExz7-8A:10 a=05RPwmwRPNYA:10 a=I4ko-sDDNxYA:10 a=ff-B7xzCdYMA:10 a=YgwN3AOMAAAA:8 a=6EZAwwaTHbGZaq6IuhIA:9 a=pILNOxqGKmIA:10 Message-ID: <55F776B5.2090203@acm.org> Date: Mon, 14 Sep 2015 21:39:01 -0400 From: Ed Cashin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Julia Lawall CC: sergey.senozhatsky@gmail.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/39] aoe: drop null test before destroy functions References: <1442146532-9100-1-git-send-email-Julia.Lawall@lip6.fr> <1442146532-9100-10-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1442146532-9100-10-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Identified-User: {2969:box320.bluehost.com:cashinwo:cashinworks.com} {sentby:smtp auth 98.192.52.118 authed with ed@cashinworks.com} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ACK. Thanks. On 09/13/2015 08:15 AM, Julia Lawall wrote: > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ expression x; @@ > -if (x != NULL) > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); > // > > Signed-off-by: Julia Lawall > > --- > drivers/block/aoe/aoedev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c > index ffd1947..efc8a8a 100644 > --- a/drivers/block/aoe/aoedev.c > +++ b/drivers/block/aoe/aoedev.c > @@ -285,8 +285,7 @@ freedev(struct aoedev *d) > e = t + d->ntargets; > for (; t < e && *t; t++) > freetgt(d, *t); > - if (d->bufpool) > - mempool_destroy(d->bufpool); > + mempool_destroy(d->bufpool); > skbpoolfree(d); > minor_free(d->sysminor); > >