From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752089AbbIOCCI (ORCPT ); Mon, 14 Sep 2015 22:02:08 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:44412 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751959AbbIOCCH (ORCPT ); Mon, 14 Sep 2015 22:02:07 -0400 Reply-To: zhenzhong.duan@oracle.com Subject: Re: [PATCH] xen: fix the check of e_pfn in xen_find_pfn_range References: <55E6D4B8.6020402@oracle.com> <55E6D7BA.9060206@suse.com> Cc: Juergen Gross , LKML , konrad.wilk@oracle.com, boris.ostrovsky@oracle.com To: david.vrabel@citrix.com From: Zhenzhong Duan Organization: Oracle Message-ID: <55F77C50.5040702@oracle.com> Date: Tue, 15 Sep 2015 10:02:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <55E6D7BA.9060206@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David Konrad just ping me on this patch. I originally think I missed to cc you but I does. Could you ack or nak it? thanks zduan 在 2015/9/2 19:04, Juergen Gross 写道: > On 09/02/2015 12:51 PM, Zhenzhong Duan wrote: >> On some numa system, after dom0 up, we see below warning even if >> there are >> enough pfn ranges could be used for remapping. >> "Unable to find available pfn range, not remapping identity pages" >> >> Fix it to avoid getting a memory region of zero size in >> xen_find_pfn_range. >> >> Signed-off-by: Zhenzhong Duan > > Reviewed-by: Juergen Gross > >> --- >> arch/x86/xen/setup.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c >> index a3a7546..c11f6b2 100644 >> --- a/arch/x86/xen/setup.c >> +++ b/arch/x86/xen/setup.c >> @@ -178,7 +178,7 @@ static unsigned long __init xen_find_pfn_range( >> e_pfn = PFN_DOWN(entry->addr + entry->size); >> >> /* We only care about E820 after this */ >> - if (e_pfn < *min_pfn) >> + if (e_pfn <= *min_pfn) >> continue; >> >> s_pfn = PFN_UP(entry->addr); >