From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751981AbbIOCPy (ORCPT ); Mon, 14 Sep 2015 22:15:54 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:45917 "EHLO e28smtp07.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbbIOCPx (ORCPT ); Mon, 14 Sep 2015 22:15:53 -0400 X-Helo: d28dlp01.in.ibm.com X-MailFrom: raghavendra.kt@linux.vnet.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Message-ID: <55F77FB6.7020806@linux.vnet.ibm.com> Date: Tue, 15 Sep 2015 07:47:26 +0530 From: Raghavendra K T Organization: IBM User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Raghavendra K T CC: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, anton@samba.org, akpm@linux-foundation.org, nacc@linux.vnet.ibm.com, gkurz@linux.vnet.ibm.com, grant.likely@linaro.org, nikunj@linux.vnet.ibm.com, vdavydov@parallels.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH V2 1/2] mm: Replace nr_node_ids for loop with for_each_node in list lru References: <1442282917-16893-1-git-send-email-raghavendra.kt@linux.vnet.ibm.com> <1442282917-16893-2-git-send-email-raghavendra.kt@linux.vnet.ibm.com> In-Reply-To: <1442282917-16893-2-git-send-email-raghavendra.kt@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15091502-0025-0000-0000-000006F4E7AC Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/15/2015 07:38 AM, Raghavendra K T wrote: > The functions used in the patch are in slowpath, which gets called > whenever alloc_super is called during mounts. > > Though this should not make difference for the architectures with > sequential numa node ids, for the powerpc which can potentially have > sparse node ids (for e.g., 4 node system having numa ids, 0,1,16,17 > is common), this patch saves some unnecessary allocations for > non existing numa nodes. > > Even without that saving, perhaps patch makes code more readable. > > [ Take memcg_aware check outside for_each loop: Vladimir] > Signed-off-by: Raghavendra K T > --- Sorry that I had misspelled Vladimir above.