From: "Wu, Songjun" <songjun.wu@atmel.com>
To: Mark Brown <broonie@kernel.org>
Cc: <nicolas.ferre@atmel.com>, <lgirdwood@gmail.com>,
<perex@perex.cz>, <tiwai@suse.com>,
<linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<robh+dt@kernel.org>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
<galak@codeaurora.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver
Date: Tue, 15 Sep 2015 11:11:53 +0800 [thread overview]
Message-ID: <55F78C79.30102@atmel.com> (raw)
In-Reply-To: <20150908122340.GC9751@sirena.org.uk>
On 9/8/2015 20:23, Mark Brown wrote:
> On Tue, Sep 08, 2015 at 05:36:13PM +0800, Wu, Songjun wrote:
>> On 9/8/2015 00:25, Mark Brown wrote:
>
>>> Sure, there's no problem at all having that structure in software but it
>>> should be possible to do this without having to represent this structure
>>> in DT. It should be possible to register the card at the same time as
>>> the rest of the components rather than needing the separate device in
>>> the DT.
>
>> Do you mean using a single entry in the DT for the whole classD system and
>> instantiate ASoC components from it.
>> For now, there are two entry, they could be combined to one entry.
>
> Yes, exactly.
>
I try to use one entry, but there is a problem.
It's about 'driver_data' in struct device.
In function snd_soc_register_card, the parameter 'card' will be set to
'driver_data' by the code 'dev_set_drvdata(card->dev, card)'.
Then some resources(eg. regmap, clock) also need be recorded by
'driver_data'. One entry could only has one 'driver_data'. I think the
best way is to create two entries, like the current dts.
What's your opinion?
next prev parent reply other threads:[~2015-09-15 3:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 5:41 [PATCH 0/2] ASoC: atmel-classd: add the Audio Class D Amplifier Songjun Wu
2015-09-01 5:41 ` [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier code Songjun Wu
2015-09-03 11:37 ` Mark Brown
2015-09-06 9:44 ` Wu, Songjun
2015-09-07 16:23 ` Mark Brown
2015-09-08 9:36 ` Wu, Songjun
2015-09-08 12:23 ` Mark Brown
2015-09-09 3:16 ` Wu, Songjun
2015-09-09 9:52 ` Mark Brown
2015-09-10 2:31 ` Wu, Songjun
2015-09-11 10:34 ` Mark Brown
2015-09-14 6:34 ` Wu, Songjun
2015-09-01 5:41 ` [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver Songjun Wu
2015-09-03 11:43 ` Mark Brown
2015-09-06 9:44 ` Wu, Songjun
2015-09-07 16:25 ` Mark Brown
2015-09-08 9:36 ` Wu, Songjun
2015-09-08 12:23 ` Mark Brown
2015-09-09 3:16 ` Wu, Songjun
2015-09-15 3:11 ` Wu, Songjun [this message]
2015-09-16 19:42 ` Mark Brown
2015-09-17 3:07 ` Wu, Songjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F78C79.30102@atmel.com \
--to=songjun.wu@atmel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).