From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752535AbbIOEKp (ORCPT ); Tue, 15 Sep 2015 00:10:45 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:58911 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751635AbbIOEKn convert rfc822-to-8bit (ORCPT ); Tue, 15 Sep 2015 00:10:43 -0400 X-AuditID: cbfee691-f79ca6d00000456a-ba-55f79a407b6c MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT Message-id: <55F79A40.2070004@samsung.com> Date: Tue, 15 Sep 2015 13:10:40 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Charles Keepax , lee.jones@linaro.org Cc: myungjoo.ham@samsung.com, sameo@linux.intel.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Subject: Re: [PATCH RESEND 5/5] mfd: arizona: Update DT doc for new mic detection bindings References: <1441787690-30148-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1441787690-30148-5-git-send-email-ckeepax@opensource.wolfsonmicro.com> <55F2884A.5000707@samsung.com> In-reply-to: <55F2884A.5000707@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOIsWRmVeSWpSXmKPExsWyRsSkRNdx1vdQgwXnWSz+TbnBbjH/yDlW i/tfjzJaXN41h83iduMKNovlb/+zWZzuZnVg97hzbQ+bx7yTgR4vJ/5m8+jbsorR4/MmuQDW KC6blNSczLLUIn27BK6MCSc2MxVMF6+4e2QGWwPjO6EuRk4OCQETiTMfW9kgbDGJC/fWA9lc HEICKxglfmy8ygJT9HX3BBaIxCxGibbFl8E6eAUEJX5MvgeU4OBgFlCXmDIlFyTMLCAicWLN f2YIW1ti2cLXzBC9Dxglbm56yAzRqyXRt+MKO4jNIqAq0XZ5AiuIzQYU3//iBhvITFGBCInu E5UgYREBP4kPO++C3cAsMI1R4t/Mg+wgNcICMRIvJgmA1AgJHGCUmNllD2JzAu09sOsPK0i9 hMAldokVW3tZIHYJSHybfAjsZgkBWYlNB5ghfpSUOLjiBssERvFZSD6bhfDZLCSfzULy2QJG llWMoqkFyQXFSelFpnrFibnFpXnpesn5uZsYgfF5+t+ziTsY7x+wPsQowMGoxMMb0f49VIg1 say4MvcQoynQQROZpUST84FJIK8k3tDYzMjC1MTU2Mjc0kxJnFdH+mewkEB6YklqdmpqQWpR fFFpTmrxIUYmDk6pBsby+liDBtmDdzQ2M19TlzdleLpq/bk5gicnCV+brMrn27x8cfu6Dcv4 7uduKqyNWzu9lv3Xwp60w2cnzrjImqCTtE+eUTu2/vCjcmezORtb9m7yaauWCsv/FqVipeB2 NtvOzVYq/0bKx7aQhVPFe+Kz/p+p2VPSfTFvcojgwRP2l1q4mBcmL1ZiKc5INNRiLipOBAB9 cbBaygIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJIsWRmVeSWpSXmKPExsVy+t9jQV2HWd9DDS4dtbT4N+UGu8X8I+dY Le5/PcpocXnXHDaL240r2CyWv/3PZnG6m9WB3ePOtT1sHvNOBnq8nPibzaNvyypGj8+b5AJY oxoYbTJSE1NSixRS85LzUzLz0m2VvIPjneNNzQwMdQ0tLcyVFPISc1NtlVx8AnTdMnOArlBS KEvMKQUKBSQWFyvp22GaEBripmsB0xih6xsSBNdjZIAGEtYwZsz8vZGx4LNYxftl3A2Mp4S6 GDk5JARMJL7unsACYYtJXLi3nq2LkYtDSGAWo0Tb4stsIAleAUGJH5PvARVxcDALyEscuZQN YapLTJmSC1H+gFHi5qaHzBDlWhJ9O66wg9gsAqoSbZcnsILYbEDx/S9usIH0igpESHSfqAQJ iwj4SXzYeZcFZA6zwDRGiX8zD7KD1AgLxEi8mCQAUiMkcIBRYmaXPYjNKaAtcWDXH9YJjEA3 Ihw3C+G4WQjHLWBkXsUokVqQXFCclJ5rlJdarlecmFtcmpeul5yfu4kRHM3PpHcwHt7lfohR gINRiYc3ov17qBBrYllxZe4hRgkOZiURXuZpQCHelMTKqtSi/Pii0pzU4kOMpkDfTWSWEk3O ByaavJJ4Q2MTMyNLI3NDCyNjcyVxXtmVz0KFBNITS1KzU1MLUotg+pg4OKUaGPXqprL19p9+ oacg4yz09pmkH+eS24qXxbd2XE7x33O6OUF8Y3X8yrc5u2s7/87N2H7t3EWXn63rtL5GrJn+ 9X2uVtjky8elPqyME5lb7s69gnfr4tNea1qezP5w1NvwG+PNjGXcLPIXLFi3p59Y1XXvYEJM /dTijb8W+wkEOYnLrfJVP3D2ZIYSS3FGoqEWc1FxIgBKa4G4/AIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Charles, On 2015년 09월 11일 16:52, Chanwoo Choi wrote: > On 2015년 09월 09일 17:34, Charles Keepax wrote: >> Signed-off-by: Charles Keepax >> --- >> Documentation/devicetree/bindings/mfd/arizona.txt | 21 +++++++++++++++++++++ >> include/dt-bindings/mfd/arizona.h | 5 +++++ >> 2 files changed, 26 insertions(+), 0 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt >> index a8fee60..b98a11b 100644 >> --- a/Documentation/devicetree/bindings/mfd/arizona.txt >> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt >> @@ -73,6 +73,27 @@ Optional properties: >> If this node is not mentioned or if the value is unknown, then >> headphone detection mode is set to HPDETL. >> >> + - wlf,micd-software-compare : Use a software comparison to determine mic >> + presence >> + - wlf,micd-detect-debounce : Additional software microphone detection >> + debounce specified in milliseconds. >> + - wlf,micd-pol-gpio : GPIO specifier for the GPIO controlling the headset >> + polarity if one exists. >> + - wlf,micd-bias-start-time : Time allowed for MICBIAS to startup prior to >> + performing microphone detection, specified as per the ARIZONA_MICD_TIME_XXX >> + defines. >> + - wlf,micd-rate : Delay between successive microphone detection measurements, >> + specified as per the ARIZONA_MICD_TIME_XXX defines. >> + - wlf,micd-dbtime : Microphone detection hardware debounces specified as the >> + number of measurements to take, valid values being 2 and 4. >> + - wlf,micd-timeout : Timeout for microphone detection, specified in >> + milliseconds. >> + - wlf,micd-force-micbias : Force MICBIAS continuously on during microphone >> + detection. >> + >> + - wlf,gpsw : Settings for the general purpose switch, set as one of the >> + ARIZONA_GPSW_XXX defines. >> + >> - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if >> they are being externally supplied. As covered in >> Documentation/devicetree/bindings/regulator/regulator.txt >> diff --git a/include/dt-bindings/mfd/arizona.h b/include/dt-bindings/mfd/arizona.h >> index c40f665..dedf46f 100644 >> --- a/include/dt-bindings/mfd/arizona.h >> +++ b/include/dt-bindings/mfd/arizona.h >> @@ -110,4 +110,9 @@ >> #define ARIZONA_ACCDET_MODE_HPM 4 >> #define ARIZONA_ACCDET_MODE_ADC 7 >> >> +#define ARIZONA_GPSW_OPEN 0 >> +#define ARIZONA_GPSW_CLOSED 1 >> +#define ARIZONA_GPSW_CLAMP_ENABLED 2 >> +#define ARIZONA_GPSW_CLAMP_DISABLED 3 >> + >> #endif >> > > Reviewed-by: Chanwoo Choi > > You may need the ack message by DT maintainer. I think that you need to add the patch description for this patch. Thanks, Chanwoo Choi