From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752484AbbIOGzr (ORCPT ); Tue, 15 Sep 2015 02:55:47 -0400 Received: from mga14.intel.com ([192.55.52.115]:61821 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751666AbbIOGzq (ORCPT ); Tue, 15 Sep 2015 02:55:46 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,533,1437462000"; d="scan'208";a="769215974" Subject: Re: [PATCH V3 00/14] perf tools: Fix gaps propagating maps To: Arnaldo Carvalho de Melo References: <1441699142-18905-1-git-send-email-adrian.hunter@intel.com> <20150908080858.GC2038@krava.brq.redhat.com> Cc: Jiri Olsa , mingo@kernel.org, kan.liang@intel.com, linux-kernel@vger.kernel.org From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <55F7C048.2000203@intel.com> Date: Tue, 15 Sep 2015 09:52:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150908080858.GC2038@krava.brq.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/09/15 11:08, Jiri Olsa wrote: > On Tue, Sep 08, 2015 at 10:58:48AM +0300, Adrian Hunter wrote: >> Hi >> >> Here is V3 of "Fix gaps propagating maps" that fixes some problems >> revealed by to d988d5ee6478 ("perf evlist: Open event on evsel cpus and threads") >> >> Changes in V3: >> >> perf tools: Remove redundant validation from perf_evlist__propagate_maps >> perf_evlist__set_maps also doesn't need to return an error anymore >> >> perf tools: Add evlist->has_user_cpus >> Adjusted due to perf_evlist__set_maps change >> >> perf tools: Make perf_evlist__create_maps() use perf_evlist__set_maps() >> Adjusted due to perf_evlist__set_maps change >> >> perf tools: Fix perf_evlist__create_syswide_maps() not propagating maps >> Adjusted due to perf_evlist__set_maps change >> >> perf tools: Fix task exit test setting maps >> Adjusted due to perf_evlist__set_maps change >> >> perf tools: Fix software clock events test setting maps >> Adjusted due to perf_evlist__set_maps change > > Acked-by: Jiri Olsa Hi Arnaldo Please don't forget these. Intel PT is broken on 4.3 without them i.e. $ tools/perf/perf --version perf version 4.3.rc1.gd25ed $ tools/perf/perf record -e intel_pt//u uname Error: The sys_perf_event_open() syscall returned with 22 (Invalid argument) for event (sched:sched_switch). Regards Adrian