From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752050AbbIOHkT (ORCPT ); Tue, 15 Sep 2015 03:40:19 -0400 Received: from arrakis.dune.hu ([78.24.191.176]:42553 "EHLO arrakis.dune.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751573AbbIOHkS (ORCPT ); Tue, 15 Sep 2015 03:40:18 -0400 Subject: Re: spi/bcm63xx: unknown CONFIG_BIG_ENDIAN To: Valentin Rothberg References: <20150915062400.GA9130@i4lab-dhcp156.informatik.uni-erlangen.de> Cc: broonie@kernel.org, Paul Bolle , ziegler@cs.fau.de, linux-kernel@vger.kernel.org From: Jonas Gorski Message-ID: <55F7CB6E.1090008@openwrt.org> Date: Tue, 15 Sep 2015 09:40:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150915062400.GA9130@i4lab-dhcp156.informatik.uni-erlangen.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Valentin, On 15.09.2015 08:24, Valentin Rothberg wrote: > Hi Jonas, > > your commit 158fcc4e050a ("spi/bcm63xx: replace custom io accessors with > standard ones") has shown up in today's Linux next tree (i.e., > next-20150915). > > This commit adds four #ifdef blocks depending on CONFIG_BIG_ENDIAN, > which is not defined in Kconfig breaking the #ifdef #else conditions. > > Is there a patch queued somewhere to add this option to Kconfig? > > I found some other candidates like '__BIG_ENDIAN' which is used in other > drivers, or 'CPU_BIG_ENDIAN' which is defined for mips. Maybe they can > be used instead. You are right, and I had fixed this in my V2 patchset from saturday, but appearently this wasn't fast enough. Mark? If you can drop patches 2 to 4 that would be easiest for me, but if you don't do rebases on your for-next branch, then I'll rewrite the patches to apply on top of the already applied old versions and send a v3. Jonas