From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751745AbbIONCT (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Sep 2015 09:02:19 -0400
Received: from mout.web.de ([212.227.15.14]:56135 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751438AbbIONCR (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Sep 2015 09:02:17 -0400
Subject: Re: [PATCH] coccinelle: tests: unsigned value cannot be lesser than
 zero
To: Andrzej Hajda <a.hajda@samsung.com>
References: <1442309232-5902-1-git-send-email-a.hajda@samsung.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Gilles Muller <Gilles.Muller@lip6.fr>, Joe Perches <joe@perches.com>,
        Nicolas Palix <nicolas.palix@imag.fr>, Michal Marek <mmarek@suse.com>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        cocci@systeme.lip6.fr
From: SF Markus Elfring <elfring@users.sourceforge.net>
X-Enigmail-Draft-Status: N1110
Message-ID: <55F816BC.5050407@users.sourceforge.net>
Date: Tue, 15 Sep 2015 15:01:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <1442309232-5902-1-git-send-email-a.hajda@samsung.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:dyJgG8Dk3Wn36L7eSgA4FZtvee8emlIjQlfYhuRKKe0r9+p4Tej
 toyQ2ZnLyVvs5ddney7VW34IbfWK4aXFRogtkBODHH4Jsq3hI/7uu5SFqNKArOQaWG69w3S
 p3uwj2ZlxbIaqf0gb6R5CR/myig8iju27F5YACHngo9CNeCDQwWueJ/blh0WNHaSCGIIE8Q
 aqcwALOIepYL/TNkQtQKw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:CuD2aIWJUGA=:5v+BuWcpp4/7Z53WHxTgmD
 uLeS0MYgqDgGRPTh+sSXKJL2oxSDulwIlkPkndDiH7c1usT0EP4IUFC+sh6dFqDzV0lzigMYY
 K7I9qxXX2oJfpgRf70SZS7uq58NQkzF9Lz6b3YH7q+ykeGl2nXMaNqxI5oo8k+kipz2rtUxi4
 t3XJvURjp+k9P5LIFM/uR8LDux5UbNLUdGsUvfr2quf1tzrSvwTaVvvinYioASwMeiIZDG9TK
 MjM4Sny+WEtlY00/yMFqpTEwKC2899OvoPh2azovTs8l+C2NJyyY5clMzUgcNgaoatu4tcnv3
 sZCC5J2BF1EaJCd5A2IpgOXlMkViKPRrZNPLB2dBByGnVeSM+BKIg5zSpcXL+4shvcqwU7L+u
 ScFY9Fgx85USgtrFcmGVGZxZ2Jc9Fpxs4xqjmSUoIRxlZzsl2bBh4OWbgxSIocxzO3GU0Ip+I
 qskeYgjdcjJa+72hYSF8DxaCIsmOlqC7fBO+yCcB41QjHLdfZLfkqfubqU8Bqz9CULXXXCQ96
 16IzlXJzDZC2n0HVWgGhs5WRyrNEbGwgE5DNmgHmhF/dPcFYBgIetwKLArRYIOIEO507d2g0d
 kvNJovxvJnf6QUkuvM3pPvPuKgImml8/BLdqCFfo4VxS/LLuH7tK3GlT7b7s9mP3moEztAYRc
 LIXE9kJEPdMbz7UQ7owNku04dd+p29y2NuhYiCdUUVMDMNi65xwT+h49Pdwq2k8iNh4yYkfld
 e/5PKwMW5RobDffEPbiyCmPAkXeaHGolB8trKw==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +@r depends on context || org || report@
> +position p;
> +typedef u8, u16, u32, u64;

Can the involved data types be restricted for unsigned types for such
a source code analysis in a more general way?


> +{unsigned char, unsigned short int, unsigned int, unsigned long, unsigned long long, size_t, u8, u16, u32, u64} v;
> +@@
> +
> +(
> +*v@p < 0
> +|
> +*v@p >= 0
> +)

How do you think about to use the following SmPL wording instead?

 v@p
(
*< 0
|
*<= 0
)

Regards,
Markus