From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752350AbbION0Q (ORCPT ); Tue, 15 Sep 2015 09:26:16 -0400 Received: from mail-io0-f179.google.com ([209.85.223.179]:36192 "EHLO mail-io0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751573AbbION0O (ORCPT ); Tue, 15 Sep 2015 09:26:14 -0400 Subject: Re: [PATCH 06/19] staging/lustre/lmv: fix potential null pointer dereference To: green@linuxhacker.ru, Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger References: <1442270495-1655259-1-git-send-email-green@linuxhacker.ru> <1442270495-1655259-7-git-send-email-green@linuxhacker.ru> Cc: Oleg Drokin , Linux Kernel Mailing List From: Trevor Woerner Message-ID: <55F81C72.7080701@gmail.com> Date: Tue, 15 Sep 2015 09:26:10 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1442270495-1655259-7-git-send-email-green@linuxhacker.ru> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/14/15 18:41, green@linuxhacker.ru wrote: > Reviewed-on: http://review.whamcloud.com/14605 I'm confused why the patch found in this email doesn't match the patch I find when I click on the above link? Some of the patches in this series match what I find on your jenkins URLs, and some do not. For example, the function call in the body of the "if" below is "sysfs_remove_link()" but the function call in the "if" body of the code I find at http://review.whamcloud.com/14605 after clicking on the "lustre/lmv/lmv_obd.c" link is "lprocfs_remove_proc_entry()". Maybe I'm not using your jenkins correctly? > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6517 > Reviewed-by: James Simmons > Reviewed-by: John L. Hammond > Reviewed-by: Dmitry Eremin > Signed-off-by: Oleg Drokin > --- > drivers/staging/lustre/lustre/lmv/lmv_obd.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c b/drivers/staging/lustre/lustre/lmv/lmv_obd.c > index 0fc0b61..cebbacf 100644 > --- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c > +++ b/drivers/staging/lustre/lustre/lmv/lmv_obd.c > @@ -593,11 +593,11 @@ static int lmv_disconnect_mdc(struct obd_device *obd, struct lmv_tgt_desc *tgt) > mdc_obd->obd_force = obd->obd_force; > mdc_obd->obd_fail = obd->obd_fail; > mdc_obd->obd_no_recov = obd->obd_no_recov; > - } > > - if (lmv->lmv_tgts_kobj) > - sysfs_remove_link(lmv->lmv_tgts_kobj, > - mdc_obd->obd_name); > + if (lmv->lmv_tgts_kobj) > + sysfs_remove_link(lmv->lmv_tgts_kobj, > + mdc_obd->obd_name); > + } > > rc = obd_fid_fini(tgt->ltd_exp->exp_obd); > if (rc)