From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752259AbbIOOGT (ORCPT ); Tue, 15 Sep 2015 10:06:19 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:36139 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751633AbbIOOGR (ORCPT ); Tue, 15 Sep 2015 10:06:17 -0400 Subject: Re: [PATCH-v2 0/3] mmc: sdhci-pxav3: Fix tabbing issue To: Ulf Hansson References: <1441625471-16315-1-git-send-email-vaibhav.hiremath@linaro.org> Cc: linux-mmc , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Rob Herring From: Vaibhav Hiremath Message-ID: <55F825D3.9070501@linaro.org> Date: Tue, 15 Sep 2015 19:36:11 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 15 September 2015 05:58 PM, Ulf Hansson wrote: > On 7 September 2015 at 13:31, Vaibhav Hiremath > wrote: >> Trivial patch-series, which fixes the tabbing issue in the driver, >> uses the BIT macro for bit fields and prints notice on -EPROBE_DEFER >> in sdhci_add_host() function on regulator unavailability. >> >> V1 => V2 >> ======== >> - Fixed all comments from Joe, mostly alignment changes >> - Separated BIT macro usage patch into new one. >> - changed error to kernel notice for EPROBE_DEFER in sdhci_add_host() >> >> Note: This patch-series should get merged before another series - >> >> [PATCH-v2 0/7] mmc: sdhci-pxav3: Enable support for PXA1928 SDCHI controller >> >> Vaibhav Hiremath (3): >> mmc: sdhci-pxav3: Fix tabbing issue >> mmc: sdhci-pxav3: Use BIT macro for bit field definitions >> mmc: sdhci: print notice on -EPROBE_DEFER in sdhci_add_host() fn >> >> drivers/mmc/host/sdhci-pxav3.c | 46 +++++++++++++++++++++--------------------- >> drivers/mmc/host/sdhci.c | 5 ++++- >> 2 files changed, 27 insertions(+), 24 deletions(-) >> >> -- >> 1.9.1 >> > > Hi Vaibhav, > > FYI, I won't be picking up any of these patches. Primarily because I > don't think they improves the code and other people also seems to > agree to that. > > Regarding patch1 and similar patches which deals with only fixing > checkpatch warnings/errors. In most cases I don't like such changes, > as they makes it harder to use "git blame" when you want to find out > which commit that introduced a change. > Honestly, I also agree with you. But recently I have been told to do these changed to get my main/feature changes accepted :) No issues, I am OK to drop them. These are just beautification changes and as you rightly said it makes 'git blame' difficult to find original change commit. Thanks, Vaibhav