From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754975AbbIOP4h (ORCPT ); Tue, 15 Sep 2015 11:56:37 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:36072 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752316AbbIOP43 (ORCPT ); Tue, 15 Sep 2015 11:56:29 -0400 Subject: Re: [PATCH] drivers: of: check input parameter name for __of_find_property To: Peng Fan References: <1441979043-19694-1-git-send-email-van.freenix@gmail.com> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Frank Rowand , Grant Likely From: Rob Herring Message-ID: <55F83FAC.5080002@kernel.org> Date: Tue, 15 Sep 2015 10:56:28 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1441979043-19694-1-git-send-email-van.freenix@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/11/2015 08:44 AM, Peng Fan wrote: > Check input parameter 'name' for __of_find_property. If name is NULL, > of_prop_cmp->strcasecmp may trigger panic. Arguably that could be a feature. Do you have a usecase where name being NULL is valid and panicking is a problem? Rob > > Signed-off-by: Peng Fan > Cc: Rob Herring > Cc: Frank Rowand > Cc: Grant Likely > --- > drivers/of/base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/base.c b/drivers/of/base.c > index 8b5a187..e41436d 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -215,7 +215,7 @@ static struct property *__of_find_property(const struct device_node *np, > { > struct property *pp; > > - if (!np) > + if (!np || !name) > return NULL; > > for (pp = np->properties; pp; pp = pp->next) { >