From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753758AbbIOQx4 (ORCPT ); Tue, 15 Sep 2015 12:53:56 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:41352 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753355AbbIOQxy (ORCPT ); Tue, 15 Sep 2015 12:53:54 -0400 Subject: Re: [PATCH v4 2/7] power: bq27x00_battery: Renaming for consistency To: Laurentiu Palcu References: <1442265973-32261-1-git-send-email-afd@ti.com> <1442265973-32261-3-git-send-email-afd@ti.com> <20150915083224.GA3166@lpalcu-desk> CC: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Dan Murphy , , From: "Andrew F. Davis" Message-ID: <55F84D04.9020501@ti.com> Date: Tue, 15 Sep 2015 11:53:24 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150915083224.GA3166@lpalcu-desk> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/15/2015 03:32 AM, Laurentiu Palcu wrote: > On Mon, Sep 14, 2015 at 04:26:08PM -0500, Andrew F. Davis wrote: >> Rename functions that are used by multiple devices. New devices >> have been added and the function names and driver name are no longer >> general enough for the functionality they provide. >> >> Signed-off-by: Andrew F. Davis >> --- >> MAINTAINERS | 4 +- >> arch/arm/configs/omap2plus_defconfig | 2 +- >> arch/unicore32/Kconfig | 2 +- >> drivers/power/Kconfig | 22 +- >> drivers/power/Makefile | 2 +- >> .../power/{bq27x00_battery.c => bq27xxx_battery.c} | 333 +++++++++++---------- > > 1000 chips! That's how many potential chips is this driver supposed to > support, after the rename, with little or no modifications.Is it even > possible to guarantee that all future chips, starting with 'bq27' in > their naming scheme, are register compatible? > After this series we support three times as many chips, and almost none of them follow the 27x00 naming (only the bq27000 and bq27200 ever did). Also almost *none* of the new chips added are register compatible, that's why this series moves register mapping to a table, but they all perform the same task (fuel gauging) in almost the same way so it works well. > Call me conservative, but when I see driver names/renames containing > wildcards, I get chills down my spine. I can probably get over single > digit wildcards but 3 digit wildcards is a little too much. :) > Perhaps just bq27x :) > I can't help but wonder what will one have to do if one single newly > released bq27xxx chip is completely different... :/ > If someday they make a part that is so different it doesn't fit in this driver then it can be the oddball with its own named driver file. Regards, Andrew > laurentiu > >