From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751987AbbIOSLk (ORCPT ); Tue, 15 Sep 2015 14:11:40 -0400 Received: from mail-ob0-f181.google.com ([209.85.214.181]:34223 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751823AbbIOSLh (ORCPT ); Tue, 15 Sep 2015 14:11:37 -0400 Subject: Re: [PATCH RFC 1/8] dt-bindings: Document the hi6220 bindings for DRM driver To: Xinwei Kong , airlied@linux.ie, corbet@lwn.net, catalin.marinas@arm.com, will.deacon@arm.com References: <1442309834-21420-1-git-send-email-kong.kongxinwei@hisilicon.com> <1442309834-21420-2-git-send-email-kong.kongxinwei@hisilicon.com> Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, xinliang.liu@linaro.org, andy.green@linaro.org, qijiwen@hisilicon.com, gongyu@hisilicon.com, haojian.zhuang@linaro.org, liguozhu@hisilicon.com, xuwei5@hisilicon.com, yinshengbao@hisilicon.com, yanhaifeng@hisilicon.com, ml.yang@hisilicon.com, yimin@huawei.com, w.f@huawei.com, puck.chen@hisilicon.com, bintian.wang@huawei.com, benjamin.gaignard@linaro.org, xuyiping@hisilicon.com, james.yanglong@hisilicon.com, fangdechun@hisilicon.com From: Rob Herring X-Enigmail-Draft-Status: N1110 Message-ID: <55F85F54.1020807@kernel.org> Date: Tue, 15 Sep 2015 13:11:32 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1442309834-21420-2-git-send-email-kong.kongxinwei@hisilicon.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/15/2015 04:37 AM, Xinwei Kong wrote: > This adds documentation of device tree bindings for the > Graphics Processing Unit of hi6220 SOC. > > Signed-off-by: Xinliang Liu > Signed-off-by: Xinwei Kong > Signed-off-by: Andy Green > Signed-off-by: Jiwen Qi > Signed-off-by: Yu Gong > --- > .../devicetree/bindings/gpu/hisilicon,hi6220.txt | 69 ++++++++++++++++++++++ > 1 file changed, 69 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpu/hisilicon,hi6220.txt > > diff --git a/Documentation/devicetree/bindings/gpu/hisilicon,hi6220.txt b/Documentation/devicetree/bindings/gpu/hisilicon,hi6220.txt > new file mode 100644 > index 0000000..173ac63 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpu/hisilicon,hi6220.txt > @@ -0,0 +1,69 @@ > + * Hisilicon hi6220 Graphics Processing Unit for HiKey board > + > + ** display-subsystem: Master device for binding DRM sub-components DRM is a Linuxism that doesn't belong in the binding. > + This master device is parent node and it will be responsible to bind all > + sub-components devices node. Are these nodes a single block in the h/w? If not, you should describe the connection of sub-nodes with of-graph instead. > + - Required properties : > + - compatible: "hisilicon,display-subsystem". > + - #address-cells, #size-cells: Must be present if the device has sub-nodes. > + - ranges: to allow probing of subdevices. > + - dma-coherent: Present if dma operations are coherent. > + > + ** ade: Graphic overlay, Graphic post-processing, display timing control. > + This device is child node of display-subsystem > + - Required properties : > + - compatible: "hisilicon,hi6220-ade". > + - reg: physical base address of the ADE register and length of memory > + region. > + - reg-names: Should contain the reg names "ade_base" and "media_base". > + - interrupt: The interrupt number to the cpu. Defines the interrupt > + by ADE. > + - clocks: The clocks needed by the ADE module. > + - clock-names: the name of the clocks. > + > + ** dsi: support mipi dsi interface > + This device is child node of display-subsystem > + - Required properties : > + - compatible: "hisilicon,hi6220-dsi". > + - reg: physical base address of the DSI register and length of memory > + region. > + - clocks: The clocks needed by the DSI module. > + - clock-names: the name of the clocks. > + - encoder-slave: phandles to a 'encoder-slave' subnode which DSI connect > + ADV7533 in order to support hdmi display. What the ADV7533 binding looks like is still being discussed. "encoder-slave" is certainly DRM specific and not how it should be done. Most likely, this needs to use the of-graph ports. Also, the ADV7533 connection is specific to HiKey. This binding should just generically describe how any bridge or panel is connected. Rob