From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752365AbbIOSZn (ORCPT ); Tue, 15 Sep 2015 14:25:43 -0400 Received: from mail-oi0-f50.google.com ([209.85.218.50]:34822 "EHLO mail-oi0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752151AbbIOSZl (ORCPT ); Tue, 15 Sep 2015 14:25:41 -0400 Subject: Re: [PATCH RFC 6/8] drm: hisilicon: Add support for fbdev To: Xinwei Kong , airlied@linux.ie, corbet@lwn.net, catalin.marinas@arm.com, will.deacon@arm.com References: <1442309834-21420-1-git-send-email-kong.kongxinwei@hisilicon.com> <1442309834-21420-7-git-send-email-kong.kongxinwei@hisilicon.com> Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, xinliang.liu@linaro.org, andy.green@linaro.org, qijiwen@hisilicon.com, gongyu@hisilicon.com, haojian.zhuang@linaro.org, liguozhu@hisilicon.com, xuwei5@hisilicon.com, yinshengbao@hisilicon.com, yanhaifeng@hisilicon.com, ml.yang@hisilicon.com, yimin@huawei.com, w.f@huawei.com, puck.chen@hisilicon.com, bintian.wang@huawei.com, benjamin.gaignard@linaro.org, xuyiping@hisilicon.com, james.yanglong@hisilicon.com, fangdechun@hisilicon.com From: Rob Herring X-Enigmail-Draft-Status: N1110 Message-ID: <55F862A1.30308@kernel.org> Date: Tue, 15 Sep 2015 13:25:37 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1442309834-21420-7-git-send-email-kong.kongxinwei@hisilicon.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/15/2015 04:37 AM, Xinwei Kong wrote: > If you config DRM_HISI_FBDEV optional, this patch will only support fbdev > mode while also supporting double buffer. This is a lot of duplicated code from CMA fbdev. Is double buffering the only reason why CMA fbdev can't be used or are there some other constraints? Double buffering in fbdev has always been a hack, so I'm guessing that is not a feature that should be added here. Rob > Signed-off-by: Xinliang Liu > Signed-off-by: Xinwei Kong > Signed-off-by: Andy Green > Signed-off-by: Jiwen Qi > Signed-off-by: Yu Gong > --- > drivers/gpu/drm/hisilicon/Kconfig | 13 + > drivers/gpu/drm/hisilicon/Makefile | 3 +- > drivers/gpu/drm/hisilicon/hisi_drm_connector.c | 4 + > drivers/gpu/drm/hisilicon/hisi_drm_drv.c | 9 + > drivers/gpu/drm/hisilicon/hisi_drm_dsi.c | 15 + > drivers/gpu/drm/hisilicon/hisi_drm_fb.h | 5 + > drivers/gpu/drm/hisilicon/hisi_drm_fbdev.c | 395 +++++++++++++++++++++++++ > drivers/gpu/drm/hisilicon/hisi_drm_fbdev.h | 24 ++ > 8 files changed, 467 insertions(+), 1 deletion(-) > create mode 100644 drivers/gpu/drm/hisilicon/hisi_drm_fbdev.c > create mode 100644 drivers/gpu/drm/hisilicon/hisi_drm_fbdev.h