From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752639AbbIOS5H (ORCPT ); Tue, 15 Sep 2015 14:57:07 -0400 Received: from mail-ob0-f176.google.com ([209.85.214.176]:35350 "EHLO mail-ob0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751074AbbIOS5E (ORCPT ); Tue, 15 Sep 2015 14:57:04 -0400 Subject: Re: [PATCH v2 2/2] irqchip: gic: Document optional Clock and Power Domain properties To: Geert Uytterhoeven , Pawel Moll , Mark Rutland , Kumar Gala , Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , Ian Campbell References: <1442261204-30931-1-git-send-email-geert+renesas@glider.be> <1442261204-30931-3-git-send-email-geert+renesas@glider.be> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org From: Rob Herring Message-ID: <55F869FD.4090900@kernel.org> Date: Tue, 15 Sep 2015 13:57:01 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1442261204-30931-3-git-send-email-geert+renesas@glider.be> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/14/2015 03:06 PM, Geert Uytterhoeven wrote: > Depending on the GIC variant, the GIC module has one or more clock > inputs. Document the optional "clocks" and "clock-names" properties, > and their possible values, based on the Technical Reference Manuals. > optional. > > Add the optional "power-domains" property. > > This will allow to describe in DT the relationship between the GIC and > the Clock and/or Power Domain topology on SoCs where this is relevant > and needed for proper operation. > > Note: As the current GIC driver doesn't support Runtime PM yet, PM > Domain constraints must be handled elsewhere in e.g. platform code. > > Signed-off-by: Geert Uytterhoeven > --- > Note: v1 was Acked-by: Rob Herring , but I didn't add > it, due to the addition of clock-names. For both: ack. > > v2: > - Add "clock-names", > - Document clock inputs on various GIC variants. > > Clock inputs are based on the following documentation: > - "ARM11 MPCore Processor Technical Reference Manual" (r2p0), > - "Cortex-A9 MPCore Technical Reference Manual" (r4p1, r2p0), > - "Cortex-A15 Technical Reference Manual" (r4p0, r2p0), > - "CoreLink GIC-400 Generic Interrupt Controller Technical Reference > Manual" (r0p1, r0p0), > - "PrimeCell Generic Interrupt Controller (PL390) Technical Reference > Manual" (r0p0). > > I could not find clock input information in: > - "ARM1176JZF Development Chip Technical Reference Manual" (r0p0), > - "Cortex-A7 MPCore processors" (r0p5, r0p3). > > Other: > - "brcm,brahma-b15-gic" seems to be always used together with > "arm,cortex-a15-gic". > > No access to datasheets: > - "qcom,msm-8660-qgic", > - "qcom,msm-qgic2". > --- > Documentation/devicetree/bindings/arm/gic.txt | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/gic.txt b/Documentation/devicetree/bindings/arm/gic.txt > index 24742853ba460223..cc56021eb60babea 100644 > --- a/Documentation/devicetree/bindings/arm/gic.txt > +++ b/Documentation/devicetree/bindings/arm/gic.txt > @@ -59,6 +59,21 @@ Optional > regions, used when the GIC doesn't have banked registers. The offset is > cpu-offset * cpu-nr. > > +- clocks : List of phandle and clock-specific pairs, one for each entry > + in clock-names. > +- clock-names : List of names for the GIC clock input(s). Valid clock names > + depend on the GIC variant: > + "ic_clk" (for "arm,arm11mp-gic") > + "PERIPHCLKEN" (for "arm,cortex-a15-gic") > + "PERIPHCLK", "PERIPHCLKEN" (for "arm,cortex-a9-gic") > + "clk" (for "arm,gic-400") > + "gclk" (for "arm,pl390") > + > +- power-domains : A phandle and PM domain specifier as defined by bindings of > + the power controller specified by phandle, used when the GIC > + is part of a Power or Clock Domain. > + > + > Example: > > intc: interrupt-controller@fff11000 { >