From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752573AbbIOXy1 (ORCPT ); Tue, 15 Sep 2015 19:54:27 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:63256 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752011AbbIOXyZ (ORCPT ); Tue, 15 Sep 2015 19:54:25 -0400 X-AuditID: cbfec7f5-f794b6d000001495-82-55f8afad5c6f Subject: Re: [PATCH v2] ARM: dts: Fix LEDs on exynos5422-odroidxu3 To: Kukjin Kim , Krzysztof Kozlowski References: <1442136736-28672-1-git-send-email-k.kozlowski.k@gmail.com> <55F8AB56.1010900@kernel.org> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <55F8AFAC.5090305@samsung.com> Date: Wed, 16 Sep 2015 08:54:20 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <55F8AB56.1010900@kernel.org> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRmVeSWpSXmKPExsVy+t/xq7pr1/8INZi3U9di/pFzrBbP//1g t3j9wtCi//FrZotNj6+xWlzeNYfNYsb5fUwO7B47Z91l99i0qpPNY/OSeo++LasYPT5vkgtg jeKySUnNySxLLdK3S+DKePZCu2ASd0Xvm8fsDYxfOboYOTkkBEwkeucsZYOwxSQu3FsPZHNx CAksZZSYsmwGlPOFUeLdwhYmkCphASeJd13LGbsYOThEBAIkLh/iAzGFBNIl1i0UBSlnFmhn lLjzdjbYUDYBY4nNy5dALZCT6O2exAJi8wpoSczdtBvMZhFQlVjS3Q02XlQgQuLU2bdsEDWC Ej8m3wOr4QSqX7BsGdhaZgE9ifsXtUDCzALyEpvXvGWewCg4C0nHLISqWUiqFjAyr2IUTS1N LihOSs810itOzC0uzUvXS87P3cQICfmvOxiXHrM6xCjAwajEwxvR/j1UiDWxrLgy9xCjBAez kgjvxpofoUK8KYmVValF+fFFpTmpxYcYpTlYlMR5Z+56HwIMh8SS1OzU1ILUIpgsEwenVAPj 4e8vGGWW6x7n6Wfq2dl0gH3ywrx3JTOk+h5vFTrzpV2+oS/bascsw7dGK2RU2TuSdB+cfWL7 e+Hbl7//yZnO8XIwjjx8ce/99PnxV+VL3qm3evZP3/79g53V8bNBJ734Zz2S9/OeFHS4trYh sOxxUsNmV2YB7hV80scP2DvstemrVlC62ZqixFKckWioxVxUnAgArFwHXnUCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16.09.2015 08:35, Kukjin Kim wrote: > On 09/13/15 18:32, Krzysztof Kozlowski wrote: >> The LEDs on Odroid XU3 family boards could not properly probe because PWM >> outputs were reduced only to PWM for fan. Fix it for Odroid XU3 and >> XU3-Lite boards by switching to usage of all 4 outputs (although the PWM >> for MIPI probably is redundant because board does not have MIPI >> connector available). >> >> This fixes warnings on dmesg: >> [ 4.838712] samsung-pwm 12dd0000.pwm: tried to request PWM channel 1 without output >> [ 4.838725] leds_pwm pwmleds: unable to request PWM for green:mmc0: -22 >> [ 4.838767] leds_pwm: probe of pwmleds failed with error -22 >> >> Signed-off-by: Krzysztof Kozlowski >> >> --- >> >> Changes since v1: >> 1. Do not rebase on patchset adding support for Odroid XU4 board. Rebase >> just on current next. >> --- > > Applied, thanks. > Thanks. This is actually a candidate for current v4.3 cycle. It fixes issue with LEDs for Odroid XU3 caused by Anand's b685d540cc26: The offending commit b685d540cc26 was merged in v4.3. I forgot to add "fixes" tag. Fixes: b685d540cc26 ("ARM: dts: Add pwm-fan node for exynos5422-odroidxu3") Can you send it to arm-soc during this cycle? For current v4.3 Bartlomiej's patch is also an important candidate: "ARM: dts: add suspend opp to exynos4412" Best regards, Krzysztof