From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751985AbbIPEMW (ORCPT <rfc822;w@1wt.eu>);
	Wed, 16 Sep 2015 00:12:22 -0400
Received: from avon.wwwdotorg.org ([70.85.31.133]:38486 "EHLO
	avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751739AbbIPEMU (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 16 Sep 2015 00:12:20 -0400
Subject: Re: [PATCH v4 3/5] dt/bindings: bcm2835: add binding documentation
 for bcm2835-aux
To: Martin Sperl <kernel@martin.sperl.org>
References: <1440405608-3995-1-git-send-email-kernel@martin.sperl.org>
 <1440405608-3995-4-git-send-email-kernel@martin.sperl.org>
 <55DD1A13.7010705@wwwdotorg.org>
 <9D45476C-88E2-4F76-AB55-9D0C7194E29C@martin.sperl.org>
Cc: Lee Jones <lee@kernel.org>, Russell King <linux@arm.linux.org.uk>,
        Mark Brown <broonie@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-spi@vger.kernel.org,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Kumar Gala <galak@codeaurora.org>
From: Stephen Warren <swarren@wwwdotorg.org>
Message-ID: <55F8EC22.7020909@wwwdotorg.org>
Date: Tue, 15 Sep 2015 21:12:18 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <9D45476C-88E2-4F76-AB55-9D0C7194E29C@martin.sperl.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/04/2015 01:26 AM, Martin Sperl wrote:
> 
>> On 26.08.2015, at 03:44, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>
>> On 08/24/2015 02:40 AM, kernel@martin.sperl.org wrote:
>>
>>> +Example:
>>> +
>>> +aux_enable: aux_enable@0x7e215004 {
>>> +	compatible = "bcrm,bcm2835-aux";
>>> +	reg = <0x7e215004 0x04>;
>>
>> I'd expect that to be <0x7e215000 0x8>;
> 
> The reason is that we just handle enable with this driver,
> which just requires access to the 0x7e215004 register.
> 
> The 0x7e215000 register (interrupt mask) could be used by a
> cascaded interrupt-controller, but as the spi and uart drivers
> can run with shared interrupts this is not a necessity.

The DT is supposed to describe the HW, not any particular SW's use of
the HW. If the HW block has 2 registers, so must the DT reg property.