* [PATCH] pinctrl: sirf: Fix module autoloading for OF
@ 2015-09-16 7:43 Javier Martinez Canillas
2015-09-16 7:51 ` Javier Martinez Canillas
0 siblings, 1 reply; 3+ messages in thread
From: Javier Martinez Canillas @ 2015-09-16 7:43 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Fabio Estevam, Sören Brinkmann,
Masahiro Yamada, Linus Walleij, Thomas Gleixner, linux-gpio,
Barry Song, Wei Chen, linux-arm-kernel
Drivers needs to export the OF id table and this be built into
the module or udev won't have the necessary information to auto
load the driver module when the device is registered by OF.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/pinctrl/sirf/pinctrl-atlas7.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pinctrl/sirf/pinctrl-atlas7.c b/drivers/pinctrl/sirf/pinctrl-atlas7.c
index 9df0c5f25824..dd6c9b7ac1ad 100644
--- a/drivers/pinctrl/sirf/pinctrl-atlas7.c
+++ b/drivers/pinctrl/sirf/pinctrl-atlas7.c
@@ -4304,6 +4304,7 @@ static const struct of_device_id atlas7_pinmux_ids[] = {
{ .compatible = "sirf,atlas7-ioc",},
{},
};
+MODULE_DEVICE_TABLE(of, atlas7_pinmux_ids);
static struct platform_driver atlas7_pinmux_driver = {
.driver = {
@@ -4702,6 +4703,7 @@ static const struct of_device_id atlas7_gpio_ids[] = {
{ .compatible = "sirf,atlas7-gpio", },
{},
};
+MODULE_DEVICE_TABLE(of, atlas7_gpio_ids);
static int atlas7_gpio_probe(struct platform_device *pdev)
{
--
2.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: sirf: Fix module autoloading for OF
2015-09-16 7:43 [PATCH] pinctrl: sirf: Fix module autoloading for OF Javier Martinez Canillas
@ 2015-09-16 7:51 ` Javier Martinez Canillas
2015-10-02 10:15 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Javier Martinez Canillas @ 2015-09-16 7:51 UTC (permalink / raw)
To: linux-kernel
Cc: Fabio Estevam, Sören Brinkmann, Masahiro Yamada,
Linus Walleij, Thomas Gleixner, linux-gpio, Barry Song, Wei Chen,
linux-arm-kernel
Hello,
On 09/16/2015 09:43 AM, Javier Martinez Canillas wrote:
> Drivers needs to export the OF id table and this be built into
> the module or udev won't have the necessary information to auto
> load the driver module when the device is registered by OF.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
Just found out that PINCTRL_SIRF is a boolean Kconfig symbol and not
a tristate one so it can't be built as a module. Sorry for the noise.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: sirf: Fix module autoloading for OF
2015-09-16 7:51 ` Javier Martinez Canillas
@ 2015-10-02 10:15 ` Linus Walleij
0 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2015-10-02 10:15 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel@vger.kernel.org, Fabio Estevam, Sören Brinkmann,
Masahiro Yamada, Thomas Gleixner, linux-gpio@vger.kernel.org,
Barry Song, Wei Chen, linux-arm-kernel@lists.infradead.org
On Wed, Sep 16, 2015 at 12:51 AM, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> On 09/16/2015 09:43 AM, Javier Martinez Canillas wrote:
>> Drivers needs to export the OF id table and this be built into
>> the module or udev won't have the necessary information to auto
>> load the driver module when the device is registered by OF.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>
> Just found out that PINCTRL_SIRF is a boolean Kconfig symbol and not
> a tristate one so it can't be built as a module. Sorry for the noise.
OK dropping this.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-02 10:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-16 7:43 [PATCH] pinctrl: sirf: Fix module autoloading for OF Javier Martinez Canillas
2015-09-16 7:51 ` Javier Martinez Canillas
2015-10-02 10:15 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox