From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753173AbbIPJ46 (ORCPT ); Wed, 16 Sep 2015 05:56:58 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:34959 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752059AbbIPJ44 (ORCPT ); Wed, 16 Sep 2015 05:56:56 -0400 X-AuditID: cbfec7f5-f794b6d000001495-61-55f93ce714a3 Subject: Re: [PATCH 12/31] drm/amdgpu: use kmemdup rather than duplicating its implementation To: Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , David Airlie References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-13-git-send-email-a.hajda@samsung.com> Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org From: Andrzej Hajda Message-id: <55F93CDB.70505@samsung.com> Date: Wed, 16 Sep 2015 11:56:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1438934377-4922-13-git-send-email-a.hajda@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsVy+t/xK7rPbX6GGlz9KWDRe+4kk8W0O7tZ LTbOWM9q8fY+kHXl63s2i8u75rBZrD1yl92B3aP10l82j+3fHrB63O8+zuTRt2UVo8fnTXIB rFFcNimpOZllqUX6dglcGQt/PGUuuM5R8fnARdYGxvnsXYycHBICJhJTdm1jgbDFJC7cW8/W xcjFISSwlFFi1oYWVgjnOaPElseHGbsYOTiEBeIlTj/QB2kQEehjlPhxSA/EFhKokTj38hYT SD2zwApGiYXHd4NNZRPQlPi7+SYbiM0roCHR0bqSFWQOi4CqxNb38iBhUYEIiVNn30KVCEr8 mHyPBaSEU8BFYtEeAxCTWUBP4v5FLZAKZgF5ic1r3jJPYBSYhaRhFkLVLCRVCxiZVzGKppYm FxQnpeca6RUn5haX5qXrJefnbmKEhPfXHYxLj1kdYhTgYFTi4XV4+SNUiDWxrLgy9xCjBAez kgjvI6ufoUK8KYmVValF+fFFpTmpxYcYpTlYlMR5Z+56HyIkkJ5YkpqdmlqQWgSTZeLglGpg nKnKfmzhvjXs9UKXd7FNiU6bEXFltTZ328lezry1jS/SVgsulN85v719sZ6ffqHu7WieGSer n7eWS15+ufr7j3epq6z3mL2Zl+9xLv1PL7vJoQMvTUUzDWdkuf69p/d69a3Mmi8qTLE1ev2n 98S376kQD1jSnTPnguBE1zcPY0xXv4laseGdlhJLcUaioRZzUXEiAId6i6prAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > index 8da6424..94bd992 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > @@ -549,12 +549,10 @@ int amdgpu_bo_set_metadata (struct amdgpu_bo *bo, void *metadata, > if (metadata == NULL) > return -EINVAL; > > - buffer = kzalloc(metadata_size, GFP_KERNEL); > + buffer = kmemdup(metadata, metadata_size, GFP_KERNEL); > if (buffer == NULL) > return -ENOMEM; > > - memcpy(buffer, metadata, metadata_size); > - > kfree(bo->metadata); > bo->metadata_flags = flags; > bo->metadata = buffer;