From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753576AbbIPJ54 (ORCPT ); Wed, 16 Sep 2015 05:57:56 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:35024 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753114AbbIPJ5z (ORCPT ); Wed, 16 Sep 2015 05:57:55 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-ce-55f93d202cff Subject: Re: [PATCH 13/31] memstick: use kmemdup rather than duplicating its implementation To: Dan Carpenter , Andrew Morton References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-14-git-send-email-a.hajda@samsung.com> Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-kernel@vger.kernel.org From: Andrzej Hajda Message-id: <55F93D15.3050806@samsung.com> Date: Wed, 16 Sep 2015 11:57:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1438934377-4922-14-git-send-email-a.hajda@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDLMWRmVeSWpSXmKPExsVy+t/xy7oKtj9DDY5vNLWYs34Nm8XGGetZ LV7/m85icXnXHDaLtUfusjuwepyY8ZvF4+PTWywefVtWMXp83iQXwBLFZZOSmpNZllqkb5fA lTH36UbWgqccFS/PHGBpYFzI3sXIySEhYCKx5dJKKFtM4sK99WxdjFwcQgJLGSVOLXvCCOE8 Z5S4eug7K0iVsECsxOajk5lBbBGBSIltnc2MILaQQI3EpJV3WUAamAVaGSWmXJ4M1sAmoCnx d/NNNhCbV0BLorHpOguIzSKgKrHmYifYIFGBCIlTZ99C1QhK/Jh8D6yGU8BF4tnpS0BxDqCh ehL3L2qBhJkF5CU2r3nLPIFRYBaSjlkIVbOQVC1gZF7FKJpamlxQnJSea6hXnJhbXJqXrpec n7uJERLGX3YwLj5mdYhRgINRiYfX4eWPUCHWxLLiytxDjBIczEoivI+sfoYK8aYkVlalFuXH F5XmpBYfYpTmYFES5527632IkEB6YklqdmpqQWoRTJaJg1OqgVH7SHqOWMZ+J9OPVYxpFpen 63WJvnogm7P2+9nmm1ab796bu23T/pmbJtnvOxyp7+0h8WLa/Endpdz31Hgm102R+uOx5Py7 K83r1uad5gw/H6z8PEJQZMJV+dXeD8TzWkRV99XeUFh95L7MZfl8oQVt80or+zmlqo7M+Z4U fpVnu6coB6fq/kwlluKMREMt5qLiRAB7rbQiXwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > --- > drivers/memstick/core/mspro_block.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c > index 922a750..1f1dd9b 100644 > --- a/drivers/memstick/core/mspro_block.c > +++ b/drivers/memstick/core/mspro_block.c > @@ -1033,12 +1033,11 @@ static int mspro_block_read_attributes(struct memstick_dev *card) > } > msb->attr_group.name = "media_attributes"; > > - buffer = kmalloc(attr_len, GFP_KERNEL); > + buffer = kmemdup((char *)attr, attr_len, GFP_KERNEL); > if (!buffer) { > rc = -ENOMEM; > goto out_free_attr; > } > - memcpy(buffer, (char *)attr, attr_len); > > for (cnt = 0; cnt < attr_count; ++cnt) { > s_attr = kzalloc(sizeof(struct mspro_sys_attr), GFP_KERNEL);