From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753625AbbIPKCn (ORCPT ); Wed, 16 Sep 2015 06:02:43 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:33826 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753554AbbIPKCl (ORCPT ); Wed, 16 Sep 2015 06:02:41 -0400 X-AuditID: cbfec7f5-f794b6d000001495-e8-55f93e25136f Subject: Re: [PATCH 15/31] misc/vmw_vmci: use kmemdup rather than duplicating its implementation To: Greg Kroah-Hartman , Dan Carpenter References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-16-git-send-email-a.hajda@samsung.com> Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-kernel@vger.kernel.org From: Andrzej Hajda Message-id: <55F93E14.6030805@samsung.com> Date: Wed, 16 Sep 2015 12:01:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1438934377-4922-16-git-send-email-a.hajda@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDLMWRmVeSWpSXmKPExsVy+t/xy7qqdj9DDfq2yVtsnLGe1eL1v+ks Fs2L17NZXN41h81i7ZG77A6sHvvnrmH3+Pj0FotH35ZVjB6fN8kFsERx2aSk5mSWpRbp2yVw ZeyZtYGl4DJHxdafG5kaGPvYuxg5OSQETCQWzGqGssUkLtxbz9bFyMUhJLCUUWLBsgVMEM5z Ron9z2+CVQkLJEn8/v4ezBYRiJeY0vOcBcQWEqiRmDznHDtIA7NAK6PElMuTWUESbAKaEn83 32QDsXkFtCSenL4F1sAioCoxo+cZ2CBRgQiJU2ffQtUISvyYfA+shlPAReLotR9ANRxAQ/Uk 7l/UAgkzC8hLbF7zlnkCo8AsJB2zEKpmIalawMi8ilE0tTS5oDgpPddIrzgxt7g0L10vOT93 EyMkjL/uYFx6zOoQowAHoxIPr8PLH6FCrIllxZW5hxglOJiVRHgfWf0MFeJNSaysSi3Kjy8q zUktPsQozcGiJM47c9f7ECGB9MSS1OzU1ILUIpgsEwenVAMj86eths4OtrxLz6zlrmffwRg3 99eFWfqLIrnvWB/STJq64kjh1jtPrkxsvXjCUf1oUGLYZdddVwOeL/95+PHzdSZ1u+Y9eVKT 1nP3Ia//umnLCtf8Vz+abiby7LqzeVPElopv6vwa3bWtP36zuj81kP/1T9tA689DqRtc//6+ Ved9dLxrq8+O60osxRmJhlrMRcWJAOdS0elfAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > --- > drivers/misc/vmw_vmci/vmci_datagram.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/misc/vmw_vmci/vmci_datagram.c b/drivers/misc/vmw_vmci/vmci_datagram.c > index 8226652..8a4b6bb 100644 > --- a/drivers/misc/vmw_vmci/vmci_datagram.c > +++ b/drivers/misc/vmw_vmci/vmci_datagram.c > @@ -276,11 +276,10 @@ static int dg_dispatch_as_host(u32 context_id, struct vmci_datagram *dg) > } > > /* We make a copy to enqueue. */ > - new_dg = kmalloc(dg_size, GFP_KERNEL); > + new_dg = kmemdup(dg, dg_size, GFP_KERNEL); > if (new_dg == NULL) > return VMCI_ERROR_NO_MEM; > > - memcpy(new_dg, dg, dg_size); > retval = vmci_ctx_enqueue_datagram(dg->dst.context, new_dg); > if (retval < VMCI_SUCCESS) { > kfree(new_dg);