From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753761AbbIPKCz (ORCPT ); Wed, 16 Sep 2015 06:02:55 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:25670 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753647AbbIPKCx (ORCPT ); Wed, 16 Sep 2015 06:02:53 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-17-55f93e4ba353 Subject: Re: [PATCH 17/31] scsi/aacraid: use kmemdup rather than duplicating its implementation To: Adaptec OEM Raid Solutions , "James E.J. Bottomley" References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-18-git-send-email-a.hajda@samsung.com> Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org From: Andrzej Hajda Message-id: <55F93E3F.20604@samsung.com> Date: Wed, 16 Sep 2015 12:02:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1438934377-4922-18-git-send-email-a.hajda@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrPLMWRmVeSWpSXmKPExsVy+t/xq7redj9DDVqOcFh8ereN1WLjjPWs Fv/X32axuLxrDptF9/UdbBZrj9xld2DzeLdjLpvH4R8/mD36tqxi9Pi8SS6AJYrLJiU1J7Ms tUjfLoEr48HROSwFB7kqPv0Wa2Ccz9HFyMkhIWAisebaLWYIW0ziwr31bF2MXBxCAksZJQ48 uM4E4TxnlGhYO5URpEpYIFHi4fobQAkODhGBFIkJVwNBwkICNRJTtl4Ea2YWWMwoceXdPHaQ BJuApsTfzTfZQGxeAQ2Juyc7wGwWAVWJnWcvg9miAhESp86+haoRlPgx+R4LiM0p4CLx9Ptm dpBdzAJ6EvcvaoGEmQXkJTavecs8gVFgFpKOWQhVs5BULWBkXsUomlqaXFCclJ5rqFecmFtc mpeul5yfu4kREsxfdjAuPmZ1iFGAg1GJh9fh5Y9QIdbEsuLK3EOMEhzMSiK8j6x+hgrxpiRW VqUW5ccXleakFh9ilOZgURLnnbvrfYiQQHpiSWp2ampBahFMlomDU6qBsWl7kn/6ceey3WcX 17PZ5pQunu+d6iXEoy7X39sffeeHzuH/DU8+nu77qnh/Yr5Vm8eUHdPXn1JoOXgp517TbXZp i+OCk+I+3W1ZerZC6d6xA3t0cs7aa2j1/WvfWtHFcrbGQJwt1zfv2qyK2i3qDyIW/Xjz6Mzm BwqK65nsZHdPFTh/8H+luxJLcUaioRZzUXEiAH1U77xiAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > --- > drivers/scsi/aacraid/commctrl.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/aacraid/commctrl.c b/drivers/scsi/aacraid/commctrl.c > index 54195a1..d2ed626 100644 > --- a/drivers/scsi/aacraid/commctrl.c > +++ b/drivers/scsi/aacraid/commctrl.c > @@ -635,15 +635,14 @@ static int aac_send_raw_srb(struct aac_dev* dev, void __user * arg) > } > } else { > struct user_sgmap* usg; > - usg = kmalloc(actual_fibsize - sizeof(struct aac_srb) > - + sizeof(struct sgmap), GFP_KERNEL); > + usg = kmemdup(upsg, > + actual_fibsize - sizeof(struct aac_srb) + sizeof(struct sgmap), > + GFP_KERNEL); > if (!usg) { > dprintk((KERN_DEBUG"aacraid: Allocation error in Raw SRB command\n")); > rcode = -ENOMEM; > goto cleanup; > } > - memcpy (usg, upsg, actual_fibsize - sizeof(struct aac_srb) > - + sizeof(struct sgmap)); > actual_fibsize = actual_fibsize64; > > for (i = 0; i < usg->count; i++) {