From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753844AbbIPKDK (ORCPT ); Wed, 16 Sep 2015 06:03:10 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:35398 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753806AbbIPKDI (ORCPT ); Wed, 16 Sep 2015 06:03:08 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-4b-55f93e59fd74 Subject: Re: [PATCH 18/31] scsi/aic7xxx: use kmemdup rather than duplicating its implementation To: Hannes Reinecke References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-19-git-send-email-a.hajda@samsung.com> Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-kernel@vger.kernel.org, "James E.J. Bottomley" , linux-scsi@vger.kernel.org From: Andrzej Hajda Message-id: <55F93E4D.8060809@samsung.com> Date: Wed, 16 Sep 2015 12:02:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1438934377-4922-19-git-send-email-a.hajda@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHLMWRmVeSWpSXmKPExsVy+t/xy7qRdj9DDf4f07HYOGM9q8WCN3vZ LP6vv81icXnXHDaL7us72CzWHrnL7sDmcfjHD2aPvi2rGD3Wb7nK4vF5k1wASxSXTUpqTmZZ apG+XQJXxsa3U1kKrvBV3HpQ38A4i6eLkYNDQsBEou9kRRcjJ5ApJnHh3no2EFtIYCmjxOmD CV2MXED2c0aJfZd+sIIkhAUSJb62fWMCsUUElCVedz9jgWiokZi8bAczSAOzwEVGiUWbtzGD JNgENCX+br4JNpVXQEvi+OFrYM0sAqoSG5bfBhsqKhAhcersW6gaQYkfk++BDeUUcJGYuu41 K8ihzAJ6EvcvaoGEmQXkJTavecs8gVFgFpKOWQhVs5BULWBkXsUomlqaXFCclJ5rqFecmFtc mpeul5yfu4kREspfdjAuPmZ1iFGAg1GJh9fh5Y9QIdbEsuLK3EOMEhzMSiK8j6x+hgrxpiRW VqUW5ccXleakFh9ilOZgURLnnbvrfYiQQHpiSWp2ampBahFMlomDU6qB0TZ43svlKl37Yt44 6zuZCV67ZyfaYX28+VtJwcaJm/5L9x1mNJ1Y1/fz49OLLlkzV1TODTI8Pn1LQMiFRKlGRj93 Bs3A4t6W7pXPFK91utUbh7c9ULVTYvQ9t5y/NSvhuclWRu3f0fvWHJn1JW/TlGW3PRWnzNq0 d7Gx6eLw+rUt0U0b9z9pUGIpzkg01GIuKk4EAG9rjnBhAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > --- > drivers/scsi/aic7xxx/aic79xx_core.c | 4 ++-- > drivers/scsi/aic7xxx/aic7xxx_core.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c b/drivers/scsi/aic7xxx/aic79xx_core.c > index 109e2c9..8592448 100644 > --- a/drivers/scsi/aic7xxx/aic79xx_core.c > +++ b/drivers/scsi/aic7xxx/aic79xx_core.c > @@ -9494,10 +9494,10 @@ ahd_loadseq(struct ahd_softc *ahd) > if (cs_count != 0) { > > cs_count *= sizeof(struct cs); > - ahd->critical_sections = kmalloc(cs_count, GFP_ATOMIC); > + ahd->critical_sections = kmemdup(cs_table, cs_count, > + GFP_ATOMIC); > if (ahd->critical_sections == NULL) > panic("ahd_loadseq: Could not malloc"); > - memcpy(ahd->critical_sections, cs_table, cs_count); > } > ahd_outb(ahd, SEQCTL0, PERRORDIS|FAILDIS|FASTMODE); > > diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c b/drivers/scsi/aic7xxx/aic7xxx_core.c > index c4829d8..3178730 100644 > --- a/drivers/scsi/aic7xxx/aic7xxx_core.c > +++ b/drivers/scsi/aic7xxx/aic7xxx_core.c > @@ -6940,10 +6940,10 @@ ahc_loadseq(struct ahc_softc *ahc) > if (cs_count != 0) { > > cs_count *= sizeof(struct cs); > - ahc->critical_sections = kmalloc(cs_count, GFP_ATOMIC); > + ahc->critical_sections = kmemdup(cs_table, cs_count, > + GFP_ATOMIC); > if (ahc->critical_sections == NULL) > panic("ahc_loadseq: Could not malloc"); > - memcpy(ahc->critical_sections, cs_table, cs_count); > } > ahc_outb(ahc, SEQCTL, PERRORDIS|FAILDIS|FASTMODE); >