From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753864AbbIPKDp (ORCPT ); Wed, 16 Sep 2015 06:03:45 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:33917 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752859AbbIPKDm (ORCPT ); Wed, 16 Sep 2015 06:03:42 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-da-55f93e7be11d Subject: Re: [PATCH 20/31] fs/cifs: use kmemdup rather than duplicating its implementation To: Steve French References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-21-git-send-email-a.hajda@samsung.com> Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org From: Andrzej Hajda Message-id: <55F93E70.6070900@samsung.com> Date: Wed, 16 Sep 2015 12:03:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1438934377-4922-21-git-send-email-a.hajda@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCLMWRmVeSWpSXmKPExsVy+t/xK7rVdj9DDfa2WlhsnLGe1eLF/13M Fpd3zWGzWHvkLrtFx8ujzA6sHnN39TF69G1ZxejxeZNcAHMUl01Kak5mWWqRvl0CV8b/iwUF hzkqft8Sb2B8y9bFyMkhIWAi0f75PiuELSZx4d56oDgXh5DAUkaJV+8+QTnPGSXefDzGDlIl LBAjMefDVyYQW0RAReJ/33JmEFtIoEZiyrwfrCANzAKLGSU+vpkJVsQmoCnxd/NNsHW8AloS e2afZAGxWQRUJb4u/gtWIyoQIXHq7FuoGkGJH5PvAdVwcHAKuEg8fBwFYjIL6Encv6gFUsEs IC+xec1b5gmMArOQNMxCqJqFpGoBI/MqRtHU0uSC4qT0XEO94sTc4tK8dL3k/NxNjJCw/bKD cfExq0OMAhyMSjy8Di9/hAqxJpYVV+YeYpTgYFYS4X1k9TNUiDclsbIqtSg/vqg0J7X4EKM0 B4uSOO/cXe9DhATSE0tSs1NTC1KLYLJMHJxSDYwBdatusRww71/4LrLXP+cmk+nTH43GEYkx zwIrpfm1JV4ckng3ac6PYvYL9xMOW7Dm9vmLCCwRL5TZlPlcM/nMyQX7J5ZsLUj123EwLv77 /47HdnU7bltumvv54pSfX0VTqoLfbLR9e22m/AQV/sQt/dIT9ulvWhP0kEe4IbTixeEb7PGy hyqVWIozEg21mIuKEwF6BvktVwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > --- > fs/cifs/smb2pdu.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c > index 070fb2a..2d6b72f 100644 > --- a/fs/cifs/smb2pdu.c > +++ b/fs/cifs/smb2pdu.c > @@ -1394,14 +1394,13 @@ SMB2_ioctl(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, > goto ioctl_exit; > } > > - *out_data = kmalloc(*plen, GFP_KERNEL); > + *out_data = kmemdup(rsp->hdr.ProtocolId + le32_to_cpu(rsp->OutputOffset), > + *plen, GFP_KERNEL); > if (*out_data == NULL) { > rc = -ENOMEM; > goto ioctl_exit; > } > > - memcpy(*out_data, rsp->hdr.ProtocolId + le32_to_cpu(rsp->OutputOffset), > - *plen); > ioctl_exit: > free_rsp_buf(resp_buftype, rsp); > return rc;