From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754039AbbIPKEs (ORCPT ); Wed, 16 Sep 2015 06:04:48 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:33991 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753344AbbIPKEp (ORCPT ); Wed, 16 Sep 2015 06:04:45 -0400 X-AuditID: cbfec7f5-f794b6d000001495-25-55f93ebbdb52 Subject: Re: [PATCH 23/31] fs/ocfs2: use kmemdup rather than duplicating its implementation To: Mark Fasheh , Joel Becker References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-24-git-send-email-a.hajda@samsung.com> Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com From: Andrzej Hajda Message-id: <55F93EAF.4080704@samsung.com> Date: Wed, 16 Sep 2015 12:04:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1438934377-4922-24-git-send-email-a.hajda@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrMLMWRmVeSWpSXmKPExsVy+t/xa7q77X6GGjw6qmuxccZ6VouT576x WFzeNYfNYu2Ru+wW585MZLPY9eYcuwObx9OLQR4Xlr1h8+jbsorRY/2WqywenzfJBbBGcdmk pOZklqUW6dslcGXMPHWctWA7b8WOH6/ZGxi/c3UxcnBICJhI7Joj3MXICWSKSVy4t56ti5GL Q0hgKaPE6itTWSCc54wSE/7MYQSpEhaIlfjb8I8JxBYRcJH40fSJBcQWEqiR2Hb4BhNIA7PA YkaJWy93s4Ek2AQ0Jf5uvglm8wpoSazc0wnWwCKgKvHv8iowW1QgQuLU2bdQNYISPybfYwG5 jhNoQeO+ShCTWUBP4v5FLZAKZgF5ic1r3jJPYBSYhaRhFkLVLCRVCxiZVzGKppYmFxQnpeca 6RUn5haX5qXrJefnbmKEBPXXHYxLj1kdYhTgYFTi4XV4+SNUiDWxrLgy9xCjBAezkgjvI6uf oUK8KYmVValF+fFFpTmpxYcYpTlYlMR5Z+56HyIkkJ5YkpqdmlqQWgSTZeLglGpgvOX2bJXm MetyqYsqXhdZJq+qTHt+cC8fy8QwubLC2Zu2vjOR2fCoc43NPIdiicgKHjVHyX1RIRdV6j3/ R3DseHNNU/r63H0cNYHsR0zOT/5l5ThFSTHC49fq3WwRd0p/LThyl8sn4ODZ2ZJxabM3PGnw Cp94Ikrz3YHaW1mXmZbuLGdttDW8rsRSnJFoqMVcVJwIAJBiXqBmAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > --- > fs/ocfs2/localalloc.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/ocfs2/localalloc.c b/fs/ocfs2/localalloc.c > index 0a4457f..194d6d6 100644 > --- a/fs/ocfs2/localalloc.c > +++ b/fs/ocfs2/localalloc.c > @@ -434,12 +434,11 @@ void ocfs2_shutdown_local_alloc(struct ocfs2_super *osb) > bh = osb->local_alloc_bh; > alloc = (struct ocfs2_dinode *) bh->b_data; > > - alloc_copy = kmalloc(bh->b_size, GFP_NOFS); > + alloc_copy = kmemdup(alloc, bh->b_size, GFP_NOFS); > if (!alloc_copy) { > status = -ENOMEM; > goto out_commit; > } > - memcpy(alloc_copy, alloc, bh->b_size); > > status = ocfs2_journal_access_di(handle, INODE_CACHE(local_alloc_inode), > bh, OCFS2_JOURNAL_ACCESS_WRITE); > @@ -1285,13 +1284,12 @@ static int ocfs2_local_alloc_slide_window(struct ocfs2_super *osb, > * local alloc shutdown won't try to double free main bitmap > * bits. Make a copy so the sync function knows which bits to > * free. */ > - alloc_copy = kmalloc(osb->local_alloc_bh->b_size, GFP_NOFS); > + alloc_copy = kmemdup(alloc, osb->local_alloc_bh->b_size, GFP_NOFS); > if (!alloc_copy) { > status = -ENOMEM; > mlog_errno(status); > goto bail; > } > - memcpy(alloc_copy, alloc, osb->local_alloc_bh->b_size); > > status = ocfs2_journal_access_di(handle, > INODE_CACHE(local_alloc_inode),