From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754116AbbIPKF7 (ORCPT ); Wed, 16 Sep 2015 06:05:59 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:34085 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751963AbbIPKF4 (ORCPT ); Wed, 16 Sep 2015 06:05:56 -0400 X-AuditID: cbfec7f5-f794b6d000001495-38-55f93f035c9b Subject: Re: [PATCH 24/31] fs/omfs: use kmemdup rather than duplicating its implementation To: Bob Copeland References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-25-git-send-email-a.hajda@samsung.com> Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-kernel@vger.kernel.org, linux-karma-devel@lists.sourceforge.net From: Andrzej Hajda Message-id: <55F93EF7.60405@samsung.com> Date: Wed, 16 Sep 2015 12:05:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1438934377-4922-25-git-send-email-a.hajda@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNLMWRmVeSWpSXmKPExsVy+t/xK7rM9j9DDeYf5LDYOGM9q0XL7e3s Fpd3zWGzWHvkLrvF5I73zA6sHnt3dTB57F7wmcmjb8sqRo/Pm+QCWKK4bFJSczLLUov07RK4 Ml7MSCn4y17x6t0jxgbGtWxdjJwcEgImEu/7zjNB2GISF+6tB4pzcQgJLGWU+DitmR3Cec4o sXbpZrAqYYEYibcLN7OC2CICqhIvJn0GiwsJ1EjMbv8N1sAssIFR4unksywgCTYBTYm/m2+C reMV0JC48HwPmM0C1Lx6VhsziC0qECFx6uxbqBpBiR+T74H1cgq4SBycsAAozgE0VE/i/kUt kDCzgLzE5jVvmScwCsxC0jELoWoWkqoFjMyrGEVTS5MLipPSc430ihNzi0vz0vWS83M3MUKC +OsOxqXHrA4xCnAwKvHwOrz8ESrEmlhWXJl7iFGCg1lJhPeR1c9QId6UxMqq1KL8+KLSnNTi Q4zSHCxK4rwzd70PERJITyxJzU5NLUgtgskycXBKNTAq9G7TV64ujQrgM/xm23zf927+7p9R IewXfbXmaFu+8Fi8VS2RL9LAkUNj9i+FVtnrsV/5kucdTTn5LEw3nd+i5IXD6kBH9bsz1dIP LBQTOXp4+vF/P6dt0/Bb8rSRsfWqmInb+tQX9v4nuxX7oj4nvL79JmJ2UsUPDRZxf61I87MK Cz61PFZiKc5INNRiLipOBAD/mHjcXgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > --- > fs/omfs/inode.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c > index 3d935c8..02af1a3 100644 > --- a/fs/omfs/inode.c > +++ b/fs/omfs/inode.c > @@ -333,12 +333,11 @@ static int omfs_get_imap(struct super_block *sb) > bh = sb_bread(sb, block++); > if (!bh) > goto nomem_free; > - *ptr = kmalloc(sb->s_blocksize, GFP_KERNEL); > + *ptr = kmemdup(bh->b_data, sb->s_blocksize, GFP_KERNEL); > if (!*ptr) { > brelse(bh); > goto nomem_free; > } > - memcpy(*ptr, bh->b_data, sb->s_blocksize); > if (count < sb->s_blocksize) > memset((void *)*ptr + count, 0xff, > sb->s_blocksize - count);