From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754425AbbIPKHe (ORCPT <rfc822;w@1wt.eu>);
	Wed, 16 Sep 2015 06:07:34 -0400
Received: from mailout2.w1.samsung.com ([210.118.77.12]:25791 "EHLO
	mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753548AbbIPKHc (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 16 Sep 2015 06:07:32 -0400
X-AuditID: cbfec7f4-f79c56d0000012ee-63-55f93f612c3c
Subject: Re: [PATCH 27/31] net/tipc: use kmemdup rather than duplicating its
 implementation
To: Jon Maloy <jon.maloy@ericsson.com>, Ying Xue <ying.xue@windriver.com>
References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com>
 <1438934377-4922-28-git-send-email-a.hajda@samsung.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        linux-kernel@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        netdev@vger.kernel.org
From: Andrzej Hajda <a.hajda@samsung.com>
Message-id: <55F93F55.70505@samsung.com>
Date: Wed, 16 Sep 2015 12:07:17 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-version: 1.0
In-reply-to: <1438934377-4922-28-git-send-email-a.hajda@samsung.com>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsVy+t/xq7qJ9j9DDdr6DSw2zljPajHnfAuL
	xf5Zl5ktLu+aw2ax9shddotjC8QsHl+/zuzA7rFl5U0mj19fr7J59G1ZxejxeZOcx/otW5kC
	WKO4bFJSczLLUov07RK4Mlrbr7MWTGevaFjE2sB4m7WLkZNDQsBE4sDJ3VC2mMSFe+vZuhi5
	OIQEljJKvHu4gBHCec4ocXHKfaAqDg5hgViJxjM+IA0iAp4S5/ubGEFsIYEaidauRiaQemaB
	E4wSHT8PgU1lE9CU+Lv5JhuIzSugIXFh9nJmEJtFQFVi7+LjLCC2qECExKmzb6FqBCV+TL4H
	FucUcJFY+vQNE8heZgE9ifsXtUDCzALyEpvXvGWewCgwC0nHLISqWUiqFjAyr2IUTS1NLihO
	Ss811CtOzC0uzUvXS87P3cQICe8vOxgXH7M6xCjAwajEw+vw8keoEGtiWXFl7iFGCQ5mJRHe
	R1Y/Q4V4UxIrq1KL8uOLSnNSiw8xSnOwKInzzt31PkRIID2xJDU7NbUgtQgmy8TBKdXAOO9j
	1Z66T5ta/lyYsqxQQXWrgeQBoa9hvHMLZ9VzfgjtdJg5IyBnq5yTwifOVQfKVO801ZnIXlsR
	d2dKHveJLeVLZ3k3RRh6LbltyeE5793TFYwbKxYsTGeV80vPrNrPfCO5wvLC9PAfWfPUDdYw
	7D6os1qf0T+bK/1Rl5LwmqtTUq8JK8bEK7EUZyQaajEXFScCAP3lbWprAgAA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ping.

Regards
Andrzej

On 08/07/2015 09:59 AM, Andrzej Hajda wrote:
> The patch was generated using fixed coccinelle semantic patch
> scripts/coccinelle/api/memdup.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
>  net/tipc/server.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/tipc/server.c b/net/tipc/server.c
> index 922e04a..c187cad 100644
> --- a/net/tipc/server.c
> +++ b/net/tipc/server.c
> @@ -411,13 +411,12 @@ static struct outqueue_entry *tipc_alloc_entry(void *data, int len)
>  	if (!entry)
>  		return NULL;
>  
> -	buf = kmalloc(len, GFP_ATOMIC);
> +	buf = kmemdup(data, len, GFP_ATOMIC);
>  	if (!buf) {
>  		kfree(entry);
>  		return NULL;
>  	}
>  
> -	memcpy(buf, data, len);
>  	entry->iov.iov_base = buf;
>  	entry->iov.iov_len = len;
>