From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753136AbbIPOPw (ORCPT ); Wed, 16 Sep 2015 10:15:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48017 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752220AbbIPOPv (ORCPT ); Wed, 16 Sep 2015 10:15:51 -0400 Subject: Re: [PATCH] scsi: provide UAPI version of scsi/sg.h and scsi/scsi_ioctl.h To: Christoph Hellwig References: <1442308888-17911-1-git-send-email-pbonzini@redhat.com> <20150916133926.GA9658@lst.de> Cc: linux-kernel@vger.kernel.org, houcheng@gmail.com, Andy Grover , James Bottomley , Douglas Gilbert , Linux SCSI List From: Paolo Bonzini X-Enigmail-Draft-Status: N1110 Message-ID: <55F97992.6050905@redhat.com> Date: Wed, 16 Sep 2015 16:15:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150916133926.GA9658@lst.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/09/2015 15:39, Christoph Hellwig wrote: > Hi Paolo, > > can you just move them to include/linux/ directly? I'm trying to cater to the objections that were made to Andy's patch. If you mean the non-UAPI headers, James wanted them to stay in scsi/; if you mean the UAPI headers, Douglas complained about the flat structure of include/linux/. > Also scsi/scsi.h has some additional ioctl defintions that should be > added to the UAPI scsi_ioctl.h. Otherwise this looks ok to me. I can do this, but I think they are obsoleted by SG_GET_SCSI_ID, except for SCSI_IOCTL_GET_PCI which is horrible anyway. :) The comment about conflicts with CDROM ioctls is also interesting. I can see why one would want to keep them out of the new canonical place for SCSI ioctls. Paolo