From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753891AbbIQHf2 (ORCPT ); Thu, 17 Sep 2015 03:35:28 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:14728 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753790AbbIQHfY (ORCPT ); Thu, 17 Sep 2015 03:35:24 -0400 X-AuditID: cbfec7f5-f794b6d000001495-8d-55fa6d396b9a Subject: Re: [PATCH v3 3/4] serial: samsung: introduce s3c24xx_serial_rx_drain_fifo() function To: Robert Baldyga , gregkh@linuxfoundation.org References: <1442321340-28167-1-git-send-email-r.baldyga@samsung.com> <1442321340-28167-4-git-send-email-r.baldyga@samsung.com> Cc: jslaby@suse.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com From: Krzysztof Kozlowski Message-id: <55FA6D36.5090600@samsung.com> Date: Thu, 17 Sep 2015 16:35:18 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1442321340-28167-4-git-send-email-r.baldyga@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrELMWRmVeSWpSXmKPExsVy+t/xK7pWub9CDWZwWDQvXs9mMWXDByaL 1y8MLS7vmsNmcWZxL7vF2iN32S0eHN7J7sDusX/uGnaPvi2rGD3Wb7nK4vF5k1wASxSXTUpq TmZZapG+XQJXxrLdPAWnWSvuzT3B3MB4kqWLkZNDQsBE4uqBXmYIW0ziwr31bF2MXBxCAksZ Jf583MwI4XxhlDiwchUbSJWwQILEth/XwTpEBNwkFv27C9XRyCixauNlsASzQLbEx+ZlYCvY BIwlNi9fAtbMK6Al8fj6OyYQm0VAVeLrorNg9aICERKnzr6FqhGU+DH5HlAvBwcn0ILb56VB TGYBPYn7F7UgpstLbF7zlnkCo8AsJA2zEKpmIalawMi8ilE0tTS5oDgpPddIrzgxt7g0L10v OT93EyMkpL/uYFx6zOoQowAHoxIPr4LLr1Ah1sSy4srcQ4wSHMxKIrws2UAh3pTEyqrUovz4 otKc1OJDjNIcLErivDN3vQ8REkhPLEnNTk0tSC2CyTJxcEo1MEYY3b82X7htq8MnQfX0hIi0 J7rxXzt3vvuQEX+gYekktj+6icvfHjZpXVfn695UW9RRUBeu3cbF21RylyntbYutQ+Wbq2dN wgXSz4Xcf+py8TDXXZaVH5vX7JRol9waFucTxh35/NSbu9JPizhYcnO+7jsStjp/b1l49Ja4 z8JbJl7SFfxVpcRSnJFoqMVcVJwIAEgofBRlAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15.09.2015 21:48, Robert Baldyga wrote: > This patch introduces s3c24xx_serial_rx_drain_fifo() which reads data > from RX FIFO and writes it to tty buffer. It also checks for special > conditions (such as 'break') and handles it. This function has been > separated from s3c24xx_serial_rx_chars_pio() as it contains code which > can be used also in DMA mode. > > Signed-off-by: Robert Baldyga > --- > drivers/tty/serial/samsung.c | 23 +++++++++++++---------- > 1 file changed, 13 insertions(+), 10 deletions(-) Thanks for splitting the code. It looks good but I don't feel experienced enough in the driver internals to give a review tag. :) Best regards, Krzysztof