From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752442AbbIQPdc (ORCPT ); Thu, 17 Sep 2015 11:33:32 -0400 Received: from mail-bl2on0071.outbound.protection.outlook.com ([65.55.169.71]:48032 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751770AbbIQPd3 (ORCPT ); Thu, 17 Sep 2015 11:33:29 -0400 X-Greylist: delayed 394 seconds by postgrey-1.27 at vger.kernel.org; Thu, 17 Sep 2015 11:33:29 EDT Authentication-Results: spf=pass (sender IP is 63.163.107.173) smtp.mailfrom=sandisk.com; lst.de; dkim=none (message not signed) header.d=none;lst.de; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160a69-f79f76d000007db2-3a-55fadd41241b Subject: Re: [PATCH v2 4/4] scsi: provide UAPI version of scsi/sg.h and scsi/scsi_ioctl.h To: Paolo Bonzini , References: <1442497338-17019-1-git-send-email-pbonzini@redhat.com> <1442497647-17778-1-git-send-email-pbonzini@redhat.com> CC: James Bottomley , Christoph Hellwig , From: Bart Van Assche Message-ID: <55FADCFF.5000104@sandisk.com> Date: Thu, 17 Sep 2015 08:32:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1442497647-17778-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHLMWRmVeSWpSXmKPExsWyRoxnka7j3V+hBj3fDSxWrj7KZHGpdwmr xeVdc9gsuq/vYLPYv+0fqwOrx+6bDWweJ+f9ZPN4v+8qm8fnTXIBLFFcNimpOZllqUX6dglc GataLrAXNDNX3GtZztbAuIqpi5GTQ0LAROLo61tQtpjEhXvr2boYuTiEBE4wSnQsuwDl7GCU +HrvLztMx/HpmxkhEpsYJdZ+PwCWEBaIlpj96TILiC0i4C7x4+0BsLFCArUSl38+BKthFsiT ePKlG8xmEzCS+PZ+Jlg9r4CWxJ0ZO8DqWQRUJVbtu8sMYosKREicOvuWDaJGUOLkzCdg9ZwC LhIHZ/9g7WLkAJppL/FgaxnEeHmJ7W/nMIPcJiGwl1Vi1qpXbBA3qEucXDKfaQKjyCwko2Yh tM9C0r6AkXkVo1huZk5xbnpqgaGRXnFiXkpmcbZecn7uJkZwrHBl7mBcMcn8EKMAB6MSD6+C y69QIdbEsuLK3EOMEhzMSiK8C/YAhXhTEiurUovy44tKc1KLDzFKc7AoifP25uqECgmkJ5ak ZqemFqQWwWSZODilGhilXideblla5XnoeMs0Adt/fnq//myw5bcXUbvTP3ndj7yOD/OvXD0R kLm//ULdal9jnUtn8+0uS++ffiSna4lq+X/Dum8z7/6dbLHgzIl528Tfp2ia7PFg3sQjPvP7 3x/S6Zztd3+lK+mUXJ19QpTloktLyJPQuJr/KgHlGy74RDzNe273x6dWiaU4I9FQi7moOBEA ag8KeZECAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMJMWRmVeSWpSXmKPExsXCtZEjRff/nV+hBm++qFmsXH2UyeJS7xJW i8u75rBZdF/fwWaxf9s/VgdWj903G9g8Ts77yebxft9VNo/Pm+QCWKK4bFJSczLLUov07RK4 Mla1XGAvaGauuNeynK2BcRVTFyMnh4SAicTx6ZsZIWwxiQv31rOB2EICGxglnv+3A7GFBaIl Zn+6zAJiiwi4Sjx/2ssCUVMrcfnnQ/YuRg4OZoEciR3bOUDCbAJGEt/ezwQr4RXQkrgzYwfY KhYBVYlV++4yg9iiAhESp86+ZYOoEZQ4OfMJWD2ngIvEwdk/WEFsZgFbiTtzdzND2PIS29/O YZ7AyD8LScssJGWzkJQtYGRexSiWm5lTnJueWWBoqFecmJeSWZytl5yfu4kRHKyckTsYn040 P8TIxMEp1cDYFbXjwsH1+RY+QbmRf9adKf8QzTnriKbCq+jP7Mcv3WM4uvXdTdPUWvkXi++m z2B8VNEff6r1BevWgxWeAWu3nqx/94sle87/7OcnX4UULJ14/qPiNMEvrPdYLOZbzlaunRHd 4trjUProsXV6RE2vcHx/f+YWf3sD2Skv428rzI2/cPPb19aFSizFGYmGWsxFxYkAUEp3/gYC AAA= X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD002;1:u5C1XSUhoncqa0hC7C8CqR0cq7Vn2sxA3UQlPW8VmiJhdaVR0ZZF7CYBN4i74l7/hzoe+GYTcNzy1aJmZ7WaPyJtDBd7s4/yLI4vhJ6xvEEi6eTLsSnklB60uKYhnOkrDASYM9C3T10h7r1MSEXbhtTOwR6vQuoxVfKrm5Fnxt0uj+Xm/Ac7GI12XxYj++Zod2mm/R478t8qS6Om2qOQbRteMbNd3m6AK0XmoPZ9oZYGafRJpxOvn2VTN7zCKPznhlzy8pcear8+FwgnSH7UkOiy20qPXswltRX/eucsjqDp8VHIXYqZR32SRIZWQ8DWgZh809WZq0P14J/6aMf0FDK08ZA1xTU4qCOHed53W88KCFm8KQLV5oELzkaA9ZAd X-Forefront-Antispam-Report: CIP:63.163.107.173;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(24454002)(479174004)(199003)(189002)(377454003)(92566002)(189998001)(11100500001)(5001830100001)(33656002)(50986999)(76176999)(87266999)(54356999)(81156007)(4001350100001)(4001540100001)(5001860100001)(5001960100002)(65816999)(23746002)(97736004)(5007970100001)(65806001)(5001770100001)(87936001)(65956001)(59896002)(47776003)(77156002)(36756003)(64706001)(62966003)(86362001)(64126003)(46102003)(106466001)(80316001)(68736005)(77096005)(50466002)(2950100001)(69596002)(83506001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR02MB1253;H:milsmgep12.sandisk.com;FPR:;SPF:Pass;PTR:ErrorRetry;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN3PR02MB1253;2:epUYskrvG9ubduR+S1xxn2dBKcIdUwdkPZ2YbKGnXQsmyf90wniPkJgSRrPvh7YnqvRShcSc8QyhY28HrSBLAy86UJUY5stqhbA6WSjUl3My+nngqO07ZxpN0k3oVnL8sx0sTJ1eCi5yfHwPJJkzWuEkQZwQ9U1ZkU2ZTBFwR5Y=;3:Dun+qkL22zL0d4fYD5siKjdJBkUxLphSfFxXJMijXYikmn45bSbmSeebW45XnhCgzmAnczHCIYrZlqkjjBR5mCb6S65sRfrEPJSm1wjiC/ozbBdmeLR55OaANbThh3WC7tm4IZRKzKdzVb1+RUOs/X5Uv+k/s52HPGs8U9zO88qpazIzHLdekTMNeC2RHBcmBLqknV6VCsSJBf5bv1JOoJmlXkzX/LTQZ+ONhwxFKNhjFaBFbrQw2IkVXP/Scq8BhnSW3apSJHYP3igoMC2H6g==;25:K/Yc1jp5XkItOps/dEDbXXPb9WiMDgOgMifQs7JqR2UtwnTlqT/ljgTKR+zJMNSnbIm3VcEbdc/LDbiTXThkxfujC1gwZJFzWx+YanjMtvabFraSlM4l1SjQ5mklZsH5wegPoKFKKyzSSacbpAngLZpv/hK6+jh7aBmBUZ6Zd1A0f/8xL1M2NxZHLEUvqmetLMGWIATexfLh16RDaAwD9HPG9Yn2GkyebVFaYkIYnfE1BOLximF3LhBNYTxLosJYBm22tOcKlnwadxwMwCGWnw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BN3PR02MB1253; X-Microsoft-Exchange-Diagnostics: 1;BN3PR02MB1253;20:MLcKIYaQEijwQuOmIa4sraQthNJn/dOvWTONb/iKpyAtszVuoVLDrNgF3YjXgsdqv9i04eJmOOZLsy+51InKeR/ZFtk2J6aurqoAF0vG3KNL/TFQhpprs/WjZew+S8UXryJEVcTO/g4fWmcC/MnEXvKh5FKe4HnQQ8pbOoCMNKaKvF8t/EqIRsv99LkhtQw6EH3qE9rHdAni8pxSUnJz8jFHnmde8ldpMT90ACROlMdbiA807LUB6V/t/7/JmbTiFRqQAWla/bOXQi9yWf9Ln5ViUdtirx4pAh47ENiV615PmaD5Sd9lff8Q/EEfvRjK/DSSTgvanKgJsufciRNG9AtiGAnbY3xlLxfUbGXk6YMppr8tVvS/gj0GFBPEf26VKVwfDOyJ1bJ60zknQGym7lZhUl4+13c+CukeVwZtkc1/3l2SGGYU+6uyfJ6EofbmafbGDOLJQX/kA/yqbn6UinFOgKPxkenga4TUQp4GKOUHMyntnoja6IuT5/0OsBZJ;4:hEtPx+I9WZ7W/e7NMKYzNJxOh/o56cmvCwbfGsUEN6t83Q25NOcx9fB5xw8qTyVRRSvi4U7psBDTN8+mZqeIaa+kDp7VXVfV6qrOcyGxNGMxpazQAYkSV8K+uB4Ph76P3Q+5p9+dAqAQzatoOuB7+wSjTab3aH6cjPEBm9Y+wri9WrxUK6MMhe2H5+/i1euIv3BLunvDekgxWcV74N2okq0hnQS8Xh+B3qaUvB65oVQu0kjxgWf7G9Bg9xZIU7KSv3Ro3k4TOOMO6oemB39uezt52+TDED2ViMdtZA+juAWmTNaBZROP0SpKg0tS9VAz/pvhvpXo1SmsZfQRTterxA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520078)(8121501046)(5005006)(3002001);SRVR:BN3PR02MB1253;BCL:0;PCL:0;RULEID:;SRVR:BN3PR02MB1253; X-Forefront-PRVS: 07025866F6 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN3PR02MB1253;23:aTILDVKjZXK6Ry9SMwqYEnmZS/RVOvoOCq6aP?= =?Windows-1252?Q?pwYo2Fgk8AkcedG9+YotECGBIWeuBDfTT1DJYj/EmjMAilG9xNaCyRDY?= =?Windows-1252?Q?pxIcRkSyff1RkXfKx+bffAqDOYdDxjYcYh2HkLXkMPkzKxUZ+w17Hai1?= =?Windows-1252?Q?g/35OHkrla35BbxNNfy9zN8grdVnQF6d2LDPu7y2IvtT/yBEiug+1bfH?= =?Windows-1252?Q?3Ix+u6oJfVm7pZ0zq9uQ7VZY87nXBwSOFySr+12oFvmpXZcCMR33VUfx?= =?Windows-1252?Q?bwPw+0rIgeGEErGlGQucZ/bzTMHJObWoxg0IpGXSQ5BlmKAbz0yWsSp7?= =?Windows-1252?Q?ZQGdPj066wrmRAJNNj7Y0o86//fk/OOxg6Gn6yNRgpKljjlwIuv4RqCV?= =?Windows-1252?Q?XJ1kH8pHAI0cKoXmiv6JSQJMy4s9mnL/iJ9ECsnEWNh4Wo53QELGnISl?= =?Windows-1252?Q?Xl0WLY+FQH6wvZTiXfoQh/lm3ed9miCRQPdf3B/HyFQCCrpu+te/5fwL?= =?Windows-1252?Q?2IT7nOHHZA+lisBDhKrgKa0t3b5ZXmCSyNfVlzH0OGsHZKM7vsHFH0Ja?= =?Windows-1252?Q?ey+ZdrIQ+RrZCQhVYj/hP5HwepNmBrDRglZs8Cat5m8bv6hsDvoCNE5/?= =?Windows-1252?Q?dI2BpPRjYa2/kG2pIu5yGk6rz3bjA5OFArSB87jR3VqcRp5RJ6vGVBJ6?= =?Windows-1252?Q?KFUGBZ8voRsVGDlffUqsur9nYlnQNBiPPxkluoVlYu71j1z/DXg34C8u?= =?Windows-1252?Q?6eS1wxYKVQ1Rj9ji5U/F/qZX2+rD94nA09zH/EH4zlW41kTaN8KNtxq+?= =?Windows-1252?Q?pWQ5ufNjcF0fuYvP0wWtOz3qQEzHcRNkRIKTXJqJ/N2W9AAmeTuH6yOI?= =?Windows-1252?Q?4cjmzf/IyS6aZLmOhIuqB+uBVy5xnGdtbQGnCd2M/0Q/twiWLbtFpAUp?= =?Windows-1252?Q?0PLFEaXeEppPlqbpCfy238KfTixgeKxTCziCo6xWoh0ZiJoIqDJs8hnC?= =?Windows-1252?Q?C3kmuQoL/l/TwI7W88VjZsiqhyYOHY6aiiXBtm11O6/pLqbRTPkadqdS?= =?Windows-1252?Q?o0kfDKwqkJj9pszS61mR3TmmoBq0HxCmMR6OMfeiEwMdXxLThQqiyTKu?= =?Windows-1252?Q?faCa5iLcK9504g+74zGI1tMCZJnsGLK2Tr+6vGI+6t3hLeDXPce52iUp?= =?Windows-1252?Q?eclrPQV30RxTKfeQ+sQfKtNzenIChM4RG656kTODXzi5CWWfQLmjuOoL?= =?Windows-1252?Q?IYRVJ03eXmN1GkdLsSIwmS5/KsLy3kiuDav3bjzM19XJBqwxDxyMzGDT?= =?Windows-1252?Q?oGy+DZLDdDGPrdLNDGpMbMun3riD2KMXzZCKQglVx8M88r6mX+BBRNwg?= =?Windows-1252?Q?/p0o2IQ673K?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR02MB1253;5:YrM+v9YbgcYDiJaSPH8gWiC9JJ+wvuQZEjO7XoSFKfLQIJr8S8Ln7r0Vf8SOv9T1he3NxRns9hA6fCuQhXcjy2ROcc9kYOs4UWtx8PizjuMB9dGj3TnIZlgLGhX2eu7xPMviRu8Hk4cdmri9dyZP6w==;24:W7DWurkl4eClcGETxVuS0bgLKVnvcglePaqLABqzEnaTrdCURfcPtOa27iduxlkp3u7Ugs3V2ixkSnVkD3COD7f/1cNefTz2GxxFDuDwZp8=;20:WO4WCyOSd20HY5zD5QNCH59xHovZkYfj2pDTRzkZg412xBMQ4lEaMpyMPxePdYMmuV5y7V7b/6rNr0FRqcdpWVDSbXiGeM819fpyv7k6DUxipJoN5dqYVygv6vOb7wOTf3LIVyIyDPCZ22yczECS0goe5KDm7dutthI4hSfppyCzx8vbL05c9NK8/747nRQ2b1+8t74DaVX+6PyADcaz6FQP/F2fGMzRnwFnQlBRM7VZNlCeF+GVerPHOrBJ9qij SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2015 15:33:22.1033 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.173];Helo=[milsmgep12.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR02MB1253 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/17/2015 06:47 AM, Paolo Bonzini wrote: > + > +#ifndef __KERNEL__ > +/* Keep in sync with SG_DEFAULT_TIMEOUT of scsi/sg.h */ > #define SG_DEFAULT_TIMEOUT (60*HZ) /* HZ == 'jiffies in 1 second' */ > #endif Is it useful and/or necessary to export this constant ? To me this looks like an implementation aspect rather than an aspect of the scsi-sg API. Bart.