From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@canonical.com>, linux-kernel@vger.kernel.org
Cc: Josh Boyer <jwboyer@fedoraproject.org>,
Adam Williamson <awilliam@redhat.com>, Ming Lin <mlin@kernel.org>,
Mike Snitzer <snitzer@redhat.com>
Subject: Re: [PATCH] block: fix bounce_end_io
Date: Thu, 17 Sep 2015 10:07:29 -0600 [thread overview]
Message-ID: <55FAE541.4020609@kernel.dk> (raw)
In-Reply-To: <1442505988-31753-1-git-send-email-ming.lei@canonical.com>
On 09/17/2015 10:06 AM, Ming Lei wrote:
> When bio bounce is involved, one new bio and its biovecs are
> cloned from the comming bio, which can be one fast-cloned bio
> from upper layer(such as dm).
>
> So it is obviously wrong to assume the start index of the coming(
> original) bio's io vector is zero, which can be any value between
> 0 and (bi_max_vecs - 1), especially in case of bio split.
>
> This patch fixes Fedora's booting oops on i386, often with the
> following kernel log together:
>
>> [ 9.026738] systemd[1]: Switching root.
>> [ 9.036467] systemd-journald[149]: Received SIGTERM from PID 1
>> (systemd).
>> [ 9.082262] BUG: Bad page state in process kworker/u5:1 pfn:372ac
>> [ 9.083989] page:f3d32ae0 count:0 mapcount:0 mapping:f2252178
>> index:0x16a
>> [ 9.085755] flags: 0x40020021(locked|lru|mappedtodisk)
>> [ 9.087284] page dumped because: page still charged to cgroup
>> [ 9.088772] bad because of flags:
>> [ 9.089731] flags: 0x21(locked|lru)
>> [ 9.090818] page->mem_cgroup:f2c3e400
Applied, thanks Ming - and thanks Adam for testing it.
--
Jens Axboe
prev parent reply other threads:[~2015-09-17 16:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 16:06 [PATCH] block: fix bounce_end_io Ming Lei
2015-09-17 16:07 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FAE541.4020609@kernel.dk \
--to=axboe@kernel.dk \
--cc=awilliam@redhat.com \
--cc=jwboyer@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=mlin@kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox