From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752610AbbIQQHd (ORCPT ); Thu, 17 Sep 2015 12:07:33 -0400 Received: from mail-ig0-f181.google.com ([209.85.213.181]:34310 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751814AbbIQQHb (ORCPT ); Thu, 17 Sep 2015 12:07:31 -0400 Subject: Re: [PATCH] block: fix bounce_end_io To: Ming Lei , linux-kernel@vger.kernel.org References: <1442505988-31753-1-git-send-email-ming.lei@canonical.com> Cc: Josh Boyer , Adam Williamson , Ming Lin , Mike Snitzer From: Jens Axboe Message-ID: <55FAE541.4020609@kernel.dk> Date: Thu, 17 Sep 2015 10:07:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1442505988-31753-1-git-send-email-ming.lei@canonical.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/17/2015 10:06 AM, Ming Lei wrote: > When bio bounce is involved, one new bio and its biovecs are > cloned from the comming bio, which can be one fast-cloned bio > from upper layer(such as dm). > > So it is obviously wrong to assume the start index of the coming( > original) bio's io vector is zero, which can be any value between > 0 and (bi_max_vecs - 1), especially in case of bio split. > > This patch fixes Fedora's booting oops on i386, often with the > following kernel log together: > >> [ 9.026738] systemd[1]: Switching root. >> [ 9.036467] systemd-journald[149]: Received SIGTERM from PID 1 >> (systemd). >> [ 9.082262] BUG: Bad page state in process kworker/u5:1 pfn:372ac >> [ 9.083989] page:f3d32ae0 count:0 mapcount:0 mapping:f2252178 >> index:0x16a >> [ 9.085755] flags: 0x40020021(locked|lru|mappedtodisk) >> [ 9.087284] page dumped because: page still charged to cgroup >> [ 9.088772] bad because of flags: >> [ 9.089731] flags: 0x21(locked|lru) >> [ 9.090818] page->mem_cgroup:f2c3e400 Applied, thanks Ming - and thanks Adam for testing it. -- Jens Axboe