From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752662AbbIRBO7 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 17 Sep 2015 21:14:59 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:11220 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752569AbbIRBO5 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 17 Sep 2015 21:14:57 -0400
Subject: Re: [RFC PATCH v4 2/4] genirq: add move_irqs() for cpu hotplug
To: Russell King - ARM Linux <linux@arm.linux.org.uk>,
        Thomas Gleixner <tglx@linutronix.de>
References: <1442467166-1460-1-git-send-email-yangyingliang@huawei.com>
 <1442467166-1460-3-git-send-email-yangyingliang@huawei.com>
 <55FAEDF6.6060000@arm.com> <alpine.DEB.2.11.1509172355260.3951@nanos>
 <20150917220944.GX21084@n2100.arm.linux.org.uk>
CC: Mark Rutland <mark.rutland@arm.com>, Marc Zyngier <marc.zyngier@arm.com>,
        Will Deacon <will.deacon@arm.com>, <linux-kernel@vger.kernel.org>,
        Hanjun Guo <hanjun.guo@linaro.org>,
        Jiang Liu <jiang.liu@linux.intel.com>,
        <linux-arm-kernel@lists.infradead.org>
From: Yang Yingliang <yangyingliang@huawei.com>
Message-ID: <55FB651D.5080101@huawei.com>
Date: Fri, 18 Sep 2015 09:13:01 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20150917220944.GX21084@n2100.arm.linux.org.uk>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.19.219]
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2015/9/18 6:09, Russell King - ARM Linux wrote:
> On Fri, Sep 18, 2015 at 12:04:06AM +0200, Thomas Gleixner wrote:
>> On Thu, 17 Sep 2015, Marc Zyngier wrote:
>>> I don't think having this prototype guarded by this #if is very useful.
>>> You can probably leave it standalone.
>>
>> Yes, there is no point if the function name is unique. Though
>> move_irqs() is rather undescriptive. irq_break_affinities() might
>> describe it quite well, but feel free to come up with soemthing better.
>
> I don't think "irq_break_affinities" is anywhere near a good name - it's
> not about always breaking affinities (moving an IRQ off one CPU onto
> another within the current affinity setting does not break the affinity.)
>
> irq_migrate_all()
>
> irq_migrate_all_off_this_cpu()
>
> irq_this_cpu_hotunplug()
>
> irq_cpu_hotunplug()
>

irq_migrate_all_off_this_cpu() describe it well, I will choose it.

Thanks,
Yang