From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753019AbbIRBUk (ORCPT <rfc822;w@1wt.eu>);
	Thu, 17 Sep 2015 21:20:40 -0400
Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:60245 "EHLO
	mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752549AbbIRBUj (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 17 Sep 2015 21:20:39 -0400
X-IronPort-AV: E=Sophos;i="5.17,549,1437462000"; 
   d="scan'208";a="75452557"
Subject: Re: [PATCH 1/4] ARM: dts: clean up Cygnus DT files
To: Florian Fainelli <f.fainelli@gmail.com>, Rob Herring <robh+dt@kernel.org>
References: <1442534282-21356-1-git-send-email-rjui@broadcom.com>
 <1442534282-21356-2-git-send-email-rjui@broadcom.com>
 <55FB65E0.50407@gmail.com>
CC: Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <bcm-kernel-feedback-list@broadcom.com>, <devicetree@vger.kernel.org>
From: Ray Jui <rjui@broadcom.com>
Message-ID: <55FB66E4.8010006@broadcom.com>
Date: Thu, 17 Sep 2015 18:20:36 -0700
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <55FB65E0.50407@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 9/17/2015 6:16 PM, Florian Fainelli wrote:
> On 17/09/15 16:57, Ray Jui wrote:
>> This patch cleans up Cygnus DT files and makes the format consistent
>> with the rest of Broadcom iProc based SoCs.
>>
>> Changes include:
>>     - Put core components into "core" node of type "simple-bus"
>>     - Put all other peripherals into "soc" node of type "simple-bus"
>>     - Move aliases into bcm-cygnus.dtsi to avoid duplications in all dts
>>       files
>>     - Ordered all device nodes under buses based on their base register
>>       addresses
>>     - Remove unused PCI I/O resource
>>     - Use label instead of full path to reference device nodes in dts
>>       files
> 
> I am fine with the changes per-se, but the review is made largely more
> difficult because you mix multiple changes at the same time, this really
> ought to be separate patches to ease the review process. Sorry for not
> picking that up earlier.

Sure! I'll break them up into individual patches as follows:
- Put core components into "core" node of type "simple-bus"
- Put all other peripherals into "soc" node of type "simple-bus"
- Move aliases into bcm-cygnus.dtsi to avoid duplications in all dts files
- Ordered all device nodes under buses based on their base register
addresses
- Remove unused PCI I/O resources
- Use label instead of full path to reference device nodes in dts files

Thanks!

Ray