From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752835AbbIRHz2 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 18 Sep 2015 03:55:28 -0400
Received: from mail-wi0-f181.google.com ([209.85.212.181]:37129 "EHLO
	mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751372AbbIRHz1 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 18 Sep 2015 03:55:27 -0400
Message-ID: <55FBC36C.2090801@linaro.org>
Date: Fri, 18 Sep 2015 09:55:24 +0200
From: Daniel Lezcano <daniel.lezcano@linaro.org>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version: 1.0
To: Caesar Wang <caesar.upstream@gmail.com>, Heiko Stuebner <heiko@sntech.de>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>
CC: linux-rockchip@lists.infradead.org, Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability
 and compatible
References: <1442476272-31723-1-git-send-email-wxt@rock-chips.com> <1442476272-31723-2-git-send-email-wxt@rock-chips.com> <55FA83D5.9010504@linaro.org> <55FA87AA.4040807@gmail.com> <55FA9099.7000903@linaro.org> <55FA93B0.40504@gmail.com>
In-Reply-To: <55FA93B0.40504@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/17/2015 12:19 PM, Caesar Wang wrote:
>
>
> 在 2015年09月17日 18:06, Daniel Lezcano 写道:
>> On 09/17/2015 11:28 AM, Caesar Wang wrote:
>>> Hi Daniel,
>>>
>>>
>>> 在 2015年09月17日 17:11, Daniel Lezcano 写道:
>>>>
>>>> Hi Caesar,
>>>>
>>>>
>>>> On 09/17/2015 09:51 AM, Caesar Wang wrote:
>>>>> Build the arm64 SoCs (e.g.: RK3368) on Rockchip platform,
>>>>> There are some failure with build up on timer driver for rockchip.
>>>>>
>>>>> logs:
>>>>> ...
>>>>> drivers/clocksource/rockchip_timer.c:156:13: error: 'NO_IRQ'
>>>>> undeclared
>>>>
>>>> I think the NO_IRQ definition is missing for ARM64.
>>>
>>> Yep, Maybe better to compatible if we don't use the 'NO_IRQ',
>>
>> Hmm, after digging into drivers/of/irq.c and kernel/irq/irqdomain.c
>>
>> when there is an error it returns zero. So NO_IRQ and -1 are not
>> correct and on the other side zero can be a valid irq. That sounds a
>> little bit fuzzy to me.
>
> I believe the 'NO_IRQ' is better select if 'NO_IRQ' is defined on ARM64
> platform.
>
>      irq = irq_of_parse_and_map(np, 0);
>
>      if (irq  == NO_IRQ)
> ...
> Also, that's ok if we instead of the 'irq < 0'  or  '!irq' , right?


Hi Caesar,

so regarding Thomas and Russel answers, let's replace NO_IRQ by '!irq'.

Thanks.

   -- Daniel


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog