From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753384AbbIRJ6H (ORCPT ); Fri, 18 Sep 2015 05:58:07 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:37118 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751416AbbIRJ6E (ORCPT ); Fri, 18 Sep 2015 05:58:04 -0400 Message-ID: <55FBE029.1000507@linaro.org> Date: Fri, 18 Sep 2015 10:58:01 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Axel Lin , Maxime Ripard CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvmem: core: Handle shift bits in-place if cell->nbits is non-zero References: <1442569855.13652.1.camel@ingics.com> In-Reply-To: <1442569855.13652.1.camel@ingics.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Axel, Thanks for the patch Acked-by: Srinivas Kandagatla I remember fixing this sometime back which was reported by static checker reported by Dan Carpenter, I forgot to send it over to wider audience. Thanks for reminding. --srini On 18/09/15 10:50, Axel Lin wrote: > It's pointless to test (cell->bit_offset || cell->bit_offset). > nvmem_shift_read_buffer_in_place() should be called when > (cell->bit_offset || cell->nbits). > > Signed-off-by: Axel Lin > --- > drivers/nvmem/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > index d3c6676..c39723a 100644 > --- a/drivers/nvmem/core.c > +++ b/drivers/nvmem/core.c > @@ -825,7 +825,7 @@ static int __nvmem_cell_read(struct nvmem_device *nvmem, > return rc; > > /* shift bits in-place */ > - if (cell->bit_offset || cell->bit_offset) > + if (cell->bit_offset || cell->nbits) > nvmem_shift_read_buffer_in_place(cell, buf); > > *len = cell->bytes; >