From: Mathias Nyman <mathias.nyman@intel.com>
To: Laura Abbott <labbott@fedoraproject.org>,
Oliver Neukum <oneukum@suse.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] Add spurious wakeup quirk for Lynxpoint controllers
Date: Fri, 18 Sep 2015 13:18:50 +0300 [thread overview]
Message-ID: <55FBE50A.6060001@intel.com> (raw)
In-Reply-To: <1441906034-5033-1-git-send-email-labbott@fedoraproject.org>
On 10.09.2015 20:27, Laura Abbott wrote:
>
> We received several reports of systems rebooting and powering on
> after an attempted shutdown. Testing showed that setting
> XHCI_SPURIOUS_WAKEUP quirk in addition to the XHCI_SPURIOUS_REBOOT
> quirk allowed the system to shutdown as expected for Lynxpoint
> xHCI controllers. Set the qurik.
>
> Signed-off-by: Laura Abbott <labbott@fedoraproject.org>
> ---
We used to have the XHCI_SPURIOUS_WAKEUP flag set for lynxpoint controllers,
but it was removed in commit:
commit b45abacde3d551c6696c6738bef4a1805d0bf27a
xhci: no switching back on non-ULT Haswell
The switch back is limited to ULT even on HP. The contrary
finding arose by bad luck in BIOS versions for testing.
This fixes spontaneous resume from S3 on some HP laptops.
Adding the SPURIOUS_WAKEUP flag back looks reasonable to me,
but I don't want to break suspend.
I don't understand how it could have caused spontaneous resume in HP laptops
in the first place, it really shouldn't do anything before shutdown.
Better ask Oliver,
Do you still have access to the HP laptop?
Any chance you could see if the flag still causes spontaneous resume?
-Mathias
next prev parent reply other threads:[~2015-09-18 10:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 17:27 [RFC][PATCH] Add spurious wakeup quirk for Lynxpoint controllers Laura Abbott
2015-09-18 10:18 ` Mathias Nyman [this message]
2015-09-18 11:36 ` Oliver Neukum
2015-09-18 16:56 ` Laura Abbott
2015-09-18 20:25 ` Oliver Neukum
2015-09-24 8:03 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FBE50A.6060001@intel.com \
--to=mathias.nyman@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=labbott@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox