From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753081AbbIRKOk (ORCPT ); Fri, 18 Sep 2015 06:14:40 -0400 Received: from mga11.intel.com ([192.55.52.93]:61467 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751418AbbIRKOi (ORCPT ); Fri, 18 Sep 2015 06:14:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,552,1437462000"; d="scan'208";a="564159220" Message-ID: <55FBE50A.6060001@intel.com> Date: Fri, 18 Sep 2015 13:18:50 +0300 From: Mathias Nyman User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Laura Abbott , Oliver Neukum CC: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH] Add spurious wakeup quirk for Lynxpoint controllers References: <1441906034-5033-1-git-send-email-labbott@fedoraproject.org> In-Reply-To: <1441906034-5033-1-git-send-email-labbott@fedoraproject.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.09.2015 20:27, Laura Abbott wrote: > > We received several reports of systems rebooting and powering on > after an attempted shutdown. Testing showed that setting > XHCI_SPURIOUS_WAKEUP quirk in addition to the XHCI_SPURIOUS_REBOOT > quirk allowed the system to shutdown as expected for Lynxpoint > xHCI controllers. Set the qurik. > > Signed-off-by: Laura Abbott > --- We used to have the XHCI_SPURIOUS_WAKEUP flag set for lynxpoint controllers, but it was removed in commit: commit b45abacde3d551c6696c6738bef4a1805d0bf27a xhci: no switching back on non-ULT Haswell The switch back is limited to ULT even on HP. The contrary finding arose by bad luck in BIOS versions for testing. This fixes spontaneous resume from S3 on some HP laptops. Adding the SPURIOUS_WAKEUP flag back looks reasonable to me, but I don't want to break suspend. I don't understand how it could have caused spontaneous resume in HP laptops in the first place, it really shouldn't do anything before shutdown. Better ask Oliver, Do you still have access to the HP laptop? Any chance you could see if the flag still causes spontaneous resume? -Mathias