From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753515AbbIRKzw (ORCPT ); Fri, 18 Sep 2015 06:55:52 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([207.82.80.143]:13914 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752436AbbIRKzu convert rfc822-to-8bit (ORCPT ); Fri, 18 Sep 2015 06:55:50 -0400 Message-ID: <55FBEDB3.3030705@arm.com> Date: Fri, 18 Sep 2015 11:55:47 +0100 From: Kapileshwar Singh User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Namhyung Kim CC: Steven Rostedt , "linux-kernel@vger.kernel.org" , Arnaldo Carvalho de Melo , Javi Merino , David Ahern , Jiri Olsa Subject: Re: [PATCH] tools lib traceevent: Mask higher bits of str addresses for 32-bit traces References: <1442488476-15366-1-git-send-email-kapileshwar.singh@arm.com> <20150917091154.575d031f@gandalf.local.home> <55FAD512.5030206@arm.com> In-Reply-To: X-OriginalArrivalTime: 18 Sep 2015 10:55:47.0782 (UTC) FILETIME=[933B8E60:01D0F200] X-MC-Unique: 1BYgdn3KSke6r2HOkxuT_g-1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Namhyung, Thanks for looking into this! On 17/09/15 16:26, Namhyung Kim wrote: > Hi, > > On Thu, Sep 17, 2015 at 11:58 PM, Kapileshwar Singh > wrote: >> Hi Steve, >> >> Thanks for looking into this! >> >> On 17/09/15 14:11, Steven Rostedt wrote: >>> On Thu, 17 Sep 2015 12:14:36 +0100 >>> Kapileshwar Singh wrote: >>> >>>> When a trace recorded on a 32-bit device is processed with a 64-bit >>>> binary, the higher 32-bits of the address need to be masked. >>>> >>>> The lack of this results in the output of the 64-bit pointer >>>> value to the trace as the 32-bit address lookup fails in find_printk. >>>> >>>> Before: >>>> burn-1778 [003] 548.600305: bputs: 0xc0046db2s: 2cec5c058d98c >>>> >>>> After: >>>> burn-1778 [003] 548.600305: bputs: 0xc0046db2s: RT throttling activated >>>> >>>> The problem occurs in PRINT_FEILD when the field is recognized as a pointer >>>> to a string (of the type const char *) >>> >>> Actually, there's two bugs here. You only fixed one of them. >>> >>>> >>>> Cc: Steven Rostedt >>>> Cc: Arnaldo Carvalho de Melo >>>> Cc: Namhyung Kim >>>> Cc: Javi Merino >>>> Cc: David Ahern >>>> Cc: Jiri Olsa >>>> Reported-by: Juri-Lelli >>>> Signed-off-by: Kapileshwar Singh >>>> --- >>>> tools/lib/traceevent/event-parse.c | 11 +++++++++++ >>>> 1 file changed, 11 insertions(+) >>>> >>>> diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c >>>> index 4d885934b919..39163ea4a048 100644 >>>> --- a/tools/lib/traceevent/event-parse.c >>>> +++ b/tools/lib/traceevent/event-parse.c >>>> @@ -3829,6 +3829,17 @@ static void print_str_arg(struct trace_seq *s, void *data, int size, >>>> if (!(field->flags & FIELD_IS_ARRAY) && >>>> field->size == pevent->long_size) { >>>> addr = *(unsigned long *)(data + field->offset); >>> >>> addr is of type unsigned long. That means if we read a 64 bit record on >>> a 32 bit machine (which is supported), this will be truncated. >>> >>> Perhaps we need to make addr into a unsigned long long, and then add: >>> >>> addr = (pevent->long_size == 8) ? >>> *(unsigned long long *)(data + field->offset) : >>> (unsigned long long )*(unsigned int *)(data + field->offset); > > What about this? (untested) > > addr = *(uint64_t *)(data + field->offset) & > ((1ULL << pevent->long_size * 8) - 1); I tested this and it works fine. > > Do we also need to consider byte endians? Maybe it'd be better adding > a helper to dereference pointers then.. In this particular case, since the address is just a key for a lookup into the printk_map, which seems like a (addr -> const char *) mapping for string literals in the trace file, the endian-ness should not matter (I could be wrong though). Regards, KP > > Thanks, > Namhyung >