From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753195AbbIRLpR (ORCPT <rfc822;w@1wt.eu>);
	Fri, 18 Sep 2015 07:45:17 -0400
Received: from devils.ext.ti.com ([198.47.26.153]:32925 "EHLO
	devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751009AbbIRLpP (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 18 Sep 2015 07:45:15 -0400
Subject: Re: [PATCH v2 04/23] ARM: davinci/common: Convert edma driver to
 handle one eDMA instance per driver
To: <vinod.koul@intel.com>, <nsekhar@ti.com>, <linux@arm.linux.org.uk>
References: <1441974442-8233-1-git-send-email-peter.ujfalusi@ti.com>
 <1441974442-8233-5-git-send-email-peter.ujfalusi@ti.com>
CC: <olof@lixom.net>, <arnd@arndb.de>, <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
        <dmaengine@vger.kernel.org>
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
Message-ID: <55FBF920.2090204@ti.com>
Date: Fri, 18 Sep 2015 14:44:32 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <1441974442-8233-5-git-send-email-peter.ujfalusi@ti.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/11/2015 03:27 PM, Peter Ujfalusi wrote:
> +	if (irq >= 0) {
> +		irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s_ccint\n",

The '\n' should not be in the format string.

> +					  dev_name(dev));
> +		ret = devm_request_irq(dev, irq, dma_irq_handler, 0, irq_name,
> +				       cc);
> +		if (ret) {
> +			dev_err(dev, "CCINT (%d) failed --> %d\n", irq, ret);
> +			return ret;
>  		}
> +	}
>  
> -		for (i = 0; i < edma_cc[j]->num_channels; i++)
> -			map_dmach_queue(j, i, info[j]->default_queue);
> +	irq = platform_get_irq_byname(pdev, "edma3_ccerrint");
> +	if (irq < 0 && node)
> +		irq = irq_of_parse_and_map(node, 2);
> +
> +	if (irq >= 0) {
> +		irq_name = devm_kasprintf(dev, GFP_KERNEL,
> +					  "%s_ccerrint\n",

Same here.

> +					  dev_name(dev));
> +		ret = devm_request_irq(dev, irq, dma_ccerr_handler, 0, irq_name,
> +				       cc);
> +		if (ret) {
> +			dev_err(dev, "CCERRINT (%d) failed --> %d\n", irq, ret);
> +			return ret;
> +		}
> +	}

-- 
Péter