From: Sasha Levin <sasha.levin@oracle.com>
To: Peter Zijlstra <peterz@infradead.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Tim Spriggs <tspriggs@apple.com>,
davej@codemonkey.org.uk, linux-kernel@vger.kernel.org
Subject: Re: unpinning an unpinned lock
Date: Fri, 18 Sep 2015 09:35:53 -0400 [thread overview]
Message-ID: <55FC1339.0@oracle.com> (raw)
In-Reply-To: <20150916141040.GA11639@twins.programming.kicks-ass.net>
On 09/16/2015 10:10 AM, Peter Zijlstra wrote:
> On Wed, Sep 16, 2015 at 12:55:35PM +0200, Peter Zijlstra wrote:
>
>> > In any case, I'll have another go at tackling this, otherwise I'll have
>> > to disable this warning for now.
>> >
>> > Note that this lockdep 'feature' is pure annotation, no actual logic was
>> > changed.
> Sasha, can you give this a spin?
>
> So there's 2 places where we take a lock out of the middle of a stack,
> and in those cases it would fail to preserve the pin_count.
The patch fixes the issue for me:
Tested-by: Sasha Levin <sasha.levin@oracle.com>
Thanks,
Sasha
next prev parent reply other threads:[~2015-09-18 13:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <C137BC9E-19DB-4D41-A9BE-DFE2AEE7CF42@apple.com>
2015-09-15 21:42 ` unpinning an unpinned lock Paul E. McKenney
2015-09-16 10:55 ` Peter Zijlstra
2015-09-16 14:10 ` Peter Zijlstra
2015-09-18 13:35 ` Sasha Levin [this message]
2015-09-23 8:46 ` [tip:locking/core] locking/lockdep: Fix hlock-> pin_count reset on lock stack rebuilds tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FC1339.0@oracle.com \
--to=sasha.levin@oracle.com \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tspriggs@apple.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox