From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752105AbbIRNgd (ORCPT ); Fri, 18 Sep 2015 09:36:33 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:23425 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316AbbIRNgc (ORCPT ); Fri, 18 Sep 2015 09:36:32 -0400 Message-ID: <55FC1339.0@oracle.com> Date: Fri, 18 Sep 2015 09:35:53 -0400 From: Sasha Levin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Peter Zijlstra , "Paul E. McKenney" CC: Tim Spriggs , davej@codemonkey.org.uk, linux-kernel@vger.kernel.org Subject: Re: unpinning an unpinned lock References: <20150915214244.GS4029@linux.vnet.ibm.com> <20150916105535.GD3816@twins.programming.kicks-ass.net> <20150916141040.GA11639@twins.programming.kicks-ass.net> In-Reply-To: <20150916141040.GA11639@twins.programming.kicks-ass.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/16/2015 10:10 AM, Peter Zijlstra wrote: > On Wed, Sep 16, 2015 at 12:55:35PM +0200, Peter Zijlstra wrote: > >> > In any case, I'll have another go at tackling this, otherwise I'll have >> > to disable this warning for now. >> > >> > Note that this lockdep 'feature' is pure annotation, no actual logic was >> > changed. > Sasha, can you give this a spin? > > So there's 2 places where we take a lock out of the middle of a stack, > and in those cases it would fail to preserve the pin_count. The patch fixes the issue for me: Tested-by: Sasha Levin Thanks, Sasha